Skip to content

Conversation

@Janin-Michel-Mathias
Copy link
Contributor

Description

...

Checklist

Source code

  • I've shared and documented any breaking change
  • I've reviewed and updated the jahia-depends

Tests

  • I've provided Unit and/or Integration Tests
  • I've updated the parent issue with required manual validations

Tip

Documentation to guide the reviews: How to do a code review

@Fgerthoffert Fgerthoffert self-requested a review May 12, 2025 12:52
Copy link
Member

@Fgerthoffert Fgerthoffert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a bad idea to use the reusable workflow here, just make sure that it does actually work, I'm not sure many projects are using it.

secrets: inherit
with:
jahia_image: jahia/jahia-ee-dev:8-SNAPSHOT
integration_tests_jahia_image: jahia/jahia-ee-dev:8-SNAPSHOT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget the prefix: ghcr.io/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants