-
Notifications
You must be signed in to change notification settings - Fork 6
chore: use reusable on code change #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
087060b to
80cf26d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a bad idea to use the reusable workflow here, just make sure that it does actually work, I'm not sure many projects are using it.
| secrets: inherit | ||
| with: | ||
| jahia_image: jahia/jahia-ee-dev:8-SNAPSHOT | ||
| integration_tests_jahia_image: jahia/jahia-ee-dev:8-SNAPSHOT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't forget the prefix: ghcr.io/
Description
...
Checklist
Source code
Tests
Tip
Documentation to guide the reviews: How to do a code review