-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Need investigate] Root component HMR works for babel but not for TypeScript? #2
Comments
This is introduced in 2.0.0. Can you try 1.1.1 to check if it get fixed? |
I have checked, there is no problem in version 1.1.1. |
Ok, so I'll revert be48fbe because it's a wrong port to the upstream changes but I thought there is no harm to keep it. |
I have published 2.0.1, please try that out! |
(Jack-Works#5)", close Jack-Works#2" This reverts commit 9458493.
Sorry i was wrong, the problem also exists in 1.1.1 |
I tried to reproduce this and found it's likely not a bug in If import { render } from 'react-dom'
import { Component } from './Component'
export function App() {
return (
<div>
<Component />
</div>
)
}
render(<App />, document.getElementById('root')!) Yes, in this case, it won't refresh but reload the whole tree. Because every time this file getting HMRed, this whole file will be re-executed. And if you re-call If it is your case, please move |
reported in #1
The text was updated successfully, but these errors were encountered: