Add a model for spectral corrections #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* create discontinuous tracking example * create dual-axis example * create mixed-orientation example * create seasonal tilt example * stickler * whatsnew * bsrn -> clear-sky sim * stickler, d'oh
stickler issues Refactor to separate out VR computation within pvlib.scaling.wvm to a new function pvlib.scaling._compute_vr. bugfix for high frequency time series in scaling.py, regarding issue 1257 add pull request number bugfix for high frequency time series in scaling.py, regarding issue 1257 Co-authored-by: Cliff Hansen <[email protected]>
* [bug] use clip instead of abs * [test] add test using repro steps * check if single axis tracker has correct aoi when sun is behind modules by comparison to fixed and limiting rotation * [sty] fix stickler * [test] oops forgot aoi key * [test] oops typo tr['aoi' * [test] set angles behind fixed to nan * [test] use smaller max angle, set nans from tracker * [doc] whatsnew singleaxis aoi fix gh1221
* Add cams.get_cams_radiation function * Revert "Add cams.get_cams_radiation function" This reverts commit d7deb80. * Fix inconsistencies Enforce the usage of the following terminology in the iotools inputs: start/end, latitude/longitude, and metadata. Also, latitude/longitude should come before start/end * Have station arg precede start/end in get_bsrn * Update get_bsrn doc string * Change output order in psm3 * Add variable map to pvgis_tmy with depreciating warning * Add variable_map to pvgis_tmy * Coverage for variable_map for read_pvigs_tmy * Add "versionchanged" to psm3 docs * Update psm3 docs * Update versionchanged * Update versionchange message * Correct ouput for get_pvgis_tmy with epw format * Update pvgis_tmy map test * Update v0.9.0.rst * Implement comments from review by kanderso-nrel * Remove 'empty' columns when an empty dataframe is returned by bsrn * Remove admonition about pvgis renaming in introtutorial.rst * Fix typo in pvigs_tmy documentation * Fix references in whatsnew * Refactor pvigs_tmy * Fix stickler * Fix issue references in whatsnew * Coverage for get_pvgis_tmy map_variables * Fix errors in whatsnew * Add double backticks in whatsnew Co-authored-by: Will Holmgren <[email protected]> * Add double backticks in whatsnew Co-authored-by: Will Holmgren <[email protected]> * Add double backticks in whatsnew Co-authored-by: Will Holmgren <[email protected]> * Add double backticks in whatsnew * Change fail version to 0.10 in test_modelchain * Coverage for deprecation warnings * Fix doublebackticks in whatsnew * Fix stickler * Replace tab with spaces in introtutorial Co-authored-by: AdamRJensen <[email protected]> Co-authored-by: Will Holmgren <[email protected]>
* fix ForecastModel.get_data handling of timezones * update pr number
* add powered logos * change README, whatsnew * add powered by logos, license to docs * blank line * link formatting * move logos to citing. move citing up, license down * one line for less vert space * typo Co-authored-by: Will Holmgren <[email protected]>
* fix various broken internal references * undo accidental change * stickler * "not controversial" but not correct either. pvlib.tmy -> pvlib.iotools
* make tables a required dep, remove requires_tables test decorator * whatsnew * add tables to 3.6-min yml * use pip for tables on 3.6 and 3.7 for windows DLL load issue * use pip tables on 3.6-min for numpy compat issue * only install tables by default if not (OSX & 3.9) * remove tables from 3.6-min * forgot the OS X part * put back requires_tables decorator * fix silly bug * reset back to 636da68 * inelegantly disable mac os/py 3.9 job * add pytables to 3.6-min * fix posix.yml condition * try different string interpolation * I don't understand azure variables so skip mac/3.9 this way instead * pin to blosc to older version to get tables working on win 3.6 and 3.7 * pin an older numexpr compatible with our min numpy for 3.6-min * promote tables to a normal import in clearsky.py
|
@Jacc0027 this PR has many commits that have already been merged. Best way ahead is probably to start over with the PR. First, update your fork's master branch from pvlib-python/master. That should avoid having all the extra commits appear here. It's good practice to commit your changes to a new branch in your fork, rather than commit the changes directly to your master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).pvlib#1278
AM_AOD_PW_spectral_correction.zip