fixed issue #7606 Searching for bibliographies and importing them triggers uncaught java.lang.IndexOutOfBoundsException #7665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noname690
changed the title
Siedlerchr
reviewed
Apr 26, 2021
| .map(cleanup::doPostCleanup) | ||
| .map(x-> { | ||
| while (!onPerformSucceed) { | ||
| Thread.onSpinWait(); |
|
Sorry, but you obviously didn't read my comment where I oultined a solution |
|
Sorry sir ,I'm sorry I didn't understand your comment. And after reading your modification, I learned a lot from them. Thank you very much for the reply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7606
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)Bug:
The parallelStream cause performSearch excute in a background thread and the Cleanup operation excute before the performSearch so it may cause an java.lang.IndexOutOfBoundsException.
The way to fix:
Use stream to instead of parallelStream and use a spinlock to prevent the Cleanup excute before the performSearch operation .
(In fact, I think use stream to instead of parallelStream can solve this problem and I test many times manually there are no bug in #7606 after this way. But I'm not sure whether this can solve the problem , could you offer me some suggestions !)