Add more unit tests to three gui classes #7635
Conversation
|
thanks, looks already good :) |
) c363e8f Update catholic-biblical-association.csl (#5360) 7e383b8 Fix locators in PU Paris-Nanterre (#5376) 83cb249 Update methods-of-information-in-medicine.csl (#5370) 5b19db4 Update taylor-and-francis-council-of-science-editors-author-date.csl (#5371) 27d116b Update harvard-cite-them-right-no-et-al.csl (#5373) e2ef408 Update ageing-and-society.csl (#5375) 16098e4 Update triangle.csl (#5369) 133d633 Create university-of-tasmania-simplified-author-date.csl (#5357) b9ecf07 Update revue-archeologique.csl (#5366) 6152cce Update journal-of-consumer-research.csl (#5358) 93f6600 Create refugee-survey-quarterly.csl (#5354) bfa3b6d Update canadian-biosystems-engineering.csl (#5362) 53e75ee update doi prefix (#5361) 5b3de98 Create archives-of-hand-and-microsurgery.csl (#5363) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: c363e8f Co-authored-by: github actions <[email protected]>
|
|
||
| @BeforeEach | ||
| public void setUp() { | ||
| // if (Globals.prefs == null) { |
There was a problem hiding this comment.
@Siedlerchr When I run this test, I get the error:
Cannot invoke "org.jabref.preferences.JabRefPreferences.getFilePreferences()" because "org.jabref.gui.Globals.prefs" is null
This is because line 84 in ExportToClipboardAction, it is calling:
Exporter defaultChoice = exporters.stream() .filter(exporter -> exporter.getName().equals(Globals.prefs.getImportExportPreferences().getLastExportExtension())) .findAny() .orElse(null);
I know we should not depend on Globals or alter the value of Globals.prefs in unit tests, but I was just trying if making Globals.prefs not null would solve the problem and it did. In this situation, how should we get arround this error the right way?
Thanks,
Ning
There was a problem hiding this comment.
Hi, as you cannot mock the Globals away, the only solution is to refactor the ExportToClipBoardAction, extend the constructor with an additional argument for PreferenceServices. As this is a bit more complicated, I just did this to show you how to do this if you encouter this again.
Edit// Can you enable https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests
than I can push my changes
There was a problem hiding this comment.
Alternatively, you can merge this branch https://github.com/JabRef/jabref/tree/ningxie1991-a3-nx into yours
There was a problem hiding this comment.
@Siedlerchr Thanks for the quick reply and help! I have merged your change into my branch. I will fix the test case now.
There was a problem hiding this comment.
@Siedlerchr For some reason this pull requests suddenly includes 19 changed files. I think something happened when I merge your branch to mine. I replaced this pull request with a new one #7636. I am closing this pull request. Please do not merge this. Thanks.
…ngxie1991-a3-nx * 'a3-nx' of https://github.com/ningxie1991/jabref: fix checkstyle issue and comment out the use of Globals Modified the tests modified the tests organized imports Add JUnit test with mocks for CopyMoreAction Added two Junit tests using mocks for the gui
This pull request contributes to issue #6207, to add more unit tests to the gui package, specifically using test doubles.
Tests added:
NewEntryActionTest
CopyMoreActionTest
ExportToClipboardActionTest
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)