Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix downloaded files moved to citation key dir #6608

Merged
merged 6 commits into from
Jun 15, 2020
Merged

Fix downloaded files moved to citation key dir #6608

merged 6 commits into from
Jun 15, 2020

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Jun 13, 2020 •
edited
Loading

Fixes #6589

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jun 13, 2020
@Siedlerchr Siedlerchr requested a review from tobiasdiez June 13, 2020 16:14
@Siedlerchr Siedlerchr changed the title Fix dowmloaded files moved to citaiton key dir Fix downloaded files moved to citation key dir Jun 13, 2020
koppor
koppor requested changes Jun 14, 2020
View reviewed changes
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nitpick 😇

src/test/java/org/jabref/logic/util/io/FileUtilTest.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/logic/util/io/FileUtil.java Show resolved Hide resolved
@Siedlerchr
Update FileUtilTest.java
fff66d2 
Remove obsolete comment
@Siedlerchr
Update FileUtilTest.java
f17cb5d 
Revert previous change., remove right comment
@Siedlerchr Siedlerchr merged commit ed96faa into master Jun 15, 2020
@Siedlerchr Siedlerchr deleted the fixFileLinkDL branch June 15, 2020 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@systemoperator systemoperator systemoperator left review comments

@koppor koppor koppor approved these changes

@tobiasdiez tobiasdiez tobiasdiez approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Download of files put them in subfolders
4 participants
@Siedlerchr @koppor @systemoperator @tobiasdiez