Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception when adding save action without selected formatter #6072

Merged
merged 22 commits into from
Mar 6, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
eb988b6
Fixes making paths of linked files relative (web urls will not be tou…
systemoperator Jan 29, 2020
f53568b
Replace link to Workspace set-up with new one (#5896)
duelle Jan 29, 2020
3078a47
Merge remote-tracking branch 'upstream/master'
Siedlerchr Jan 31, 2020
6dcc424
Merge remote-tracking branch 'upstream/master'
Siedlerchr Feb 3, 2020
522d8c9
Merge remote-tracking branch 'upstream/master'
Siedlerchr Feb 5, 2020
38d11e6
Merge remote-tracking branch 'upstream/master'
Siedlerchr Feb 10, 2020
8bf0c77
Merge remote-tracking branch 'upstream/master'
Siedlerchr Feb 11, 2020
9c80645
Merge remote-tracking branch 'upstream/master'
Siedlerchr Feb 12, 2020
ef4bf81
Merge remote-tracking branch 'upstream/master'
Siedlerchr Feb 13, 2020
859e826
Merge remote-tracking branch 'upstream/master'
Siedlerchr Feb 18, 2020
c23b8de
Merge remote-tracking branch 'upstream/master'
Siedlerchr Feb 20, 2020
f22a640
Merge remote-tracking branch 'upstream/master'
Siedlerchr Feb 20, 2020
6392f5b
Merge remote-tracking branch 'upstream/master'
Siedlerchr Feb 24, 2020
be7d2e2
Merge remote-tracking branch 'upstream/master'
Siedlerchr Feb 25, 2020
30146a3
Merge remote-tracking branch 'upstream/master'
Siedlerchr Feb 27, 2020
070f3cc
Merge remote-tracking branch 'upstream/master'
Siedlerchr Feb 28, 2020
74ea799
Merge remote-tracking branch 'upstream/master'
Siedlerchr Mar 2, 2020
b03c4dd
Merge remote-tracking branch 'upstream/master'
Siedlerchr Mar 2, 2020
cb699a4
Merge remote-tracking branch 'upstream/master'
Siedlerchr Mar 4, 2020
439172b
Merge remote-tracking branch 'upstream/master'
Siedlerchr Mar 5, 2020
9817b8b
Merge remote-tracking branch 'upstream/master'
Siedlerchr Mar 6, 2020
ff0c8aa
Fix exception when adding save action without selected formatter
Siedlerchr Mar 6, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
- We fixed an issue where the group and the link column were not updated after changing the entry in the main table. [#5985](https://github.com/JabRef/jabref/issues/5985)
- We fixed an issue where reordering the groups was not possible after inserting an article. [#6008](https://github.com/JabRef/jabref/issues/6008)
- We fixed an issue where citation styles except the default "Preview" could not be used. [#56220](https://github.com/JabRef/jabref/issues/5622)
- We fixed an issue where an exception was thrown when adding a save action without a selected formatter in the library properties [#6069](https://github.com/JabRef/jabref/issues/6069)

### Removed

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ private void buildLayout() {
actionsList = new ListView<>(actions);
actionsList.setMinHeight(100.0);
actionsList.getSelectionModel().setSelectionMode(SelectionMode.SINGLE);

new ViewModelListCellFactory<FieldFormatterCleanup>()
.withText(action -> action.getField().getDisplayName() + ": " + action.getFormatter().getName())
.withStringTooltip(action -> action.getFormatter().getDescription())
Expand Down Expand Up @@ -179,6 +180,7 @@ private GridPane getSelectorPanel() {
.withStringTooltip(Formatter::getDescription)
.install(formattersCombobox);
EasyBind.subscribe(formattersCombobox.valueProperty(), e -> updateDescription());
formattersCombobox.getSelectionModel().selectFirst();
builder.add(formattersCombobox, 3, 1);

addButton = new Button(Localization.lang("Add"));
Expand Down