Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrates fetching citation counts online (Google Scholar, Semantic Scholar and OpenCitations), integrates a general structure for fechting reference metadata and integrates a general websocket server for JabRef #5943
Integrates fetching citation counts online (Google Scholar, Semantic Scholar and OpenCitations), integrates a general structure for fechting reference metadata and integrates a general websocket server for JabRef #5943
Changes from 40 commits
75132ea
6d03ac8
0b7343c
22145ee
a6b2b1f
42b868d
d57cea1
665d1b7
032a908
d0c3d75
9a4d9ad
56c1e69
575c5f2
c397f45
91b2adb
32d7400
4325489
9eb0e4f
057b13b
39362ec
1f324c9
99e5d77
ac89007
4382482
f1d10ad
395b99b
42b04d8
d949eb6
07a4016
2dddb05
c887fc0
b68a648
17c8878
c8604f7
dce8ce2
9f48fd2
511e503
eb68e09
10ae06b
599741c
dfdb9dc
e7b8773
a5b1aaa
bdb3fb8
df2118e
73ef19b
0866a98
e7f217f
afbbe4e
fa4be18
6c69fca
5a56a5a
6a37291
c9e61fd
c19d22e
44041c2
6c08a96
9267a45
e0754b5
dcf0e66
d684755
4158caa
5a56bac
24ce4d3
5b76d3e
967d134
de6dbb4
2331754
915227f
b035310
d3151ab
893324b
8b46044
aebf2b6
f5dc536
70e2022
541bdb8
8552691
29bf17a
756f342
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The purpose of this class is not clear to me (as it passes everything directly to its super class). Moreover, we have
BackgroundTask
which is usually used to for background tasks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I needed this class, so that I can access the methods from outside, meaning the change is, that they are public.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the localization test is failing because of this statement. Please concatenate the strings inside the Localization:lang-expressions to single strings and add them to the l10n-resources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only to the english resource file. Translations are handled by crowdin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a method in
WebFetchets
which returns the three fetchers and then refactor the code to a foreach loop.