fixes #4610. Changed the way the GroupDialog description is displayed.

[LeonhardWolz]

fixes #4610

• Changed GroupDialog description Node to TextFlow
• GroupDialog is no longer resizable
• Changed the layout of the GroupDialog window to be more horizontal
• OK Button is only enabled after some input

---

• Change in CHANGELOG.md described
• Tests created for changes
• Manually tested changed features in running JabRef
• Screenshots added in PR description (for bigger UI changes)
• Ensured that the git commit message is a good one
• Check documentation status (Issue created for outdated help page at help.jabref.org?)

[Siedlerchr]

Why don't you directly change this to a TextFlow instead of the replacement? As far as I see the text is fixed, so no need to dynamically replace it.

e.g. create multiple TextFlow objects for each part of the string and then add them to a FlowPane:
This was my approach in one of the OpenOffice dialogs:

        Text startText = new Text(start);
        Text inBetweenText = new Text(inBetween);
        inBetweenText.setStyle("-fx-font-weight: bold");
        Text endText = new Text(end);
       FlowPane flow = new FlowPane(startText, inBetweenText, endText);

[Siedlerchr]

This should be also possible in the other case. Anoter idea would be to reuse the methods we have in TooltipTextUtil or extend it with a normal method:

[LeonhardWolz]

I thought about doing that but then you would need to break up every localized string into smaller substrings. And i didn't want to touch the localization.
Or am i misunderstanding what you are saying?

Is there any reason why you would want it to be a FlowPane instead of a TextFlow element?

And your second suggestion is to put the createFormattedDescription method into the TooltipTextUtil class?

Thanks for your feedback. This is my first pr for a public repository so thank you for helping.

[Siedlerchr]

Okay, if you don't want to touch it it's fine.
Regarding the Tooltip Class. For the search tooltips someone created that class and we also have tests in place for it so the idea is to simply rename that class to TextUtils or simliar and add a method which works for normal texts.

TextFlow should be fine, in the openOffice case I had to use a FlowPane cause the text was inside a table.

[tobiasdiez]

The code looks good to me and we can merge it as it is now. Nonetheless, Christoph is right and it would be better to replace the HTML completely by styled javafx text modules (with corresponding css style classes defined in the Base.css). Since this is a bit of work as you need to fumble around with the localization and it's not utterly important, I let you decide if you want to work on this or invest your time in something else (e.g. fixing another issue ;-) ).

[LeonhardWolz]

The code looks good to me and we can merge it as it is now. Nonetheless, Christoph is right and it would be better to replace the HTML completely by styled javafx text modules (with corresponding css style classes defined in the Base.css). Since this is a bit of work as you need to fumble around with the localization and it's not utterly important, I let you decide if you want to work on this or invest your time in something else (e.g. fixing another issue ;-) ).

I definetly agree that this should be done the right way at some point, but im not really confident to touch the localization. I'm going to move to another issue, so this pr can be merged. 😄

[LeonhardWolz]

Ah i think i just noticed a bug. Please wait with merging.

[Siedlerchr]

Could you please also take a look at #4678

[LeonhardWolz]

Ok so i tried to automatically create a database when the user tried to create a new group without a open database, but i couldn't get it to run. The code to add the group to the open database always ran before the new database was created.

In the end i gave up and i just created a warning when the user tries to create a group without a database. I hope i made no mistakes while adding the localization.

Could you please also take a look at #4678

This error never occurred when i tried it. The report is a little thin and i couldn't recreate it.

If everything looks good to you, you can merge this pr.

[Siedlerchr]

To not confuse real externals shared SQL databases with the internal bib-"database", we changed the wording to library - Bibliothek.
Please change that

[LeonhardWolz]

fixed

[tobiasdiez]

Thanks for the quick follow-up (and sorry for being somewhat pedantic ;-) ).