Pdf exporter - delete xmp actions in the menu bar and the cli option #3947
Conversation
Adding a new exporter for xmp export in a .xmp file.
…for generating a single .xmp for every bib entry
johannes-manner
changed the title
|
I think having a |
Deleted the -xmp cli option, because the pdf exporter has now the same functionality and is embedded within the common cli exporter infrastructure.
|
I deleted the cli option -xmp (integrated with #3756), because the new XmpPdfExporter now enables the cli interaction via the -o exporter mechanism. Maybe, we can automize the writing to xmp via a preference setting. I discussed this yesterday with @stefan-kolb. Imagine a workflow, where I save my bib database and all changed entries are written to the linked pdfs. I would try to implement this in another PR. |
johannes-manner
changed the title
johannes-manner
added
the
status: ready-for-review
|
|
||
| @Override | ||
| public void export(BibDatabaseContext databaseContext, Path pdfFile, Charset encoding, List<BibEntry> entries) throws Exception { | ||
| if (pdfFile.toString().endsWith(".pdf")) { |
There was a problem hiding this comment.
Is this necessary? I think for an export it should not play a role if my flie is named test.asdf for export, as long as the format is correct?
There was a problem hiding this comment.
Yes, it is necessary, because the xmp write functionality in this case tries to load a pdf file and writes the xmp metadata explicitly only to pdf files. Other usage makes no sense here.
There is also the xmp exporter, where you can use file names like "test.asdf" to write your metadata
|
Please have a look at the faling exporter test. Then we can merge |
* upstream/master: Pdf exporter - delete xmp actions in the menu bar and the cli option (#3947) Improve search performance (#3950) New Crowdin translations (#3949) Update dependencies for junit, mockito and checkstyle (#3951) Add XMP Exporter (#3895) Switch colors of search icon for the two search modes (#3871) # Conflicts: # src/main/java/org/jabref/gui/search/GlobalSearchBar.java
The idea is, to use a new exporter for writting bib entries to pdf metadata.
It enables users to select entries and export these entries via File->Export Selected Entries to a pdf file.
This exporter can also be used within the -o cli infrastructure.
java -jar JabRef.jar -o path/article.pdf,pdf path/entries.bib
Therefore, the xmp cli and the xmp actions in the menu bar can be deleted.
Opinions?