Skip to content

fix(ai): ensure entries are populated when exporting group chat #14651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CXZHANG0508 wants to merge 9 commits into from
Closed

fix(ai): ensure entries are populated when exporting group chat #14651

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2bc05cc
fix(ai): prioritize passed entries for group chat export
CXZHANG0508 Dec 18, 2025
5a11e7f
fixed the formatting issue
CXZHANG0508 Dec 18, 2025
85aa957
prioritize passed entries and handle selection conflicts
CXZHANG0508 Dec 18, 2025
e805f3c
Eliminate the unnecessary null check
CXZHANG0508 Dec 19, 2025
90b8825
Merge branch 'main' into fix-group-export-entries
CXZHANG0508 Dec 27, 2025
f1bc19d
Merge remote-tracking branch 'upstream/main' into fix-group-export-en…
CXZHANG0508 Dec 27, 2025
a61db36
change the location of my commit
CXZHANG0508 Dec 27, 2025
b62349f
Merge remote-tracking branch 'origin/fix-group-export-entries' into f…
CXZHANG0508 Dec 27, 2025
b13ca84
add - in log
CXZHANG0508 Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
- We fixed an issue where keybindings could not be edited and saved. [#14237](https://github.com/JabRef/jabref/issues/14237)
- We readded the missing gui commands for importing and exporting preferences. [#14492](https://github.com/JabRef/jabref/pull/14492)
- We fixed an issue where reordering linked files via drag and drop was no longer possible. [#14627](https://github.com/JabRef/jabref/pull/14627)
- We fixed empty entries list when exporting AI chat from a group. [#14647](https://github.com/JabRef/jabref/issues/14647)

### Removed

Expand Down
4 changes: 3 additions & 1 deletion jabgui/src/main/java/org/jabref/gui/ai/components/aichat/AiChatComponent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,9 @@ public AiChatComponent(AiService aiService,
TaskExecutor taskExecutor
) {
this.aiService = aiService;
this.entries = stateManager.getSelectedEntries();
this.entries = (entries != null && !entries.isEmpty())
? entries
: stateManager.getSelectedEntries();

@koppor koppor Dec 18, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange code!

When is entries null? Is it a different mode? Is the caller doing something wrong?

@CXZHANG0508 CXZHANG0508 Dec 18, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized that while the previous code fixed the "chat with group" issue, it introduced a regression for standard multi-selection.
Specifically, when right-clicking a multi-selection to start a chat, the UI often passes only the single focused row, causing the multi-selection to be lost.
I have now modified the logic to handle both scenarios:

  1. It detects if the passed entry is just a subset of the current multi-selection (fixing the right-click issue).
  2. It correctly prioritizes the passed entries for Group Chat .
    I believe that if we don't add the option to directly chat with a group when creating a new library, the entries will be empty when exported. However, I think this might be permissible; otherwise, this option should be disabled.

this.bibDatabaseContext = bibDatabaseContext;
this.aiPreferences = aiPreferences;
this.entryTypesManager = entryTypesManager;
Expand Down
Loading