Skip to content

Conversation

@manojalluri
Copy link
Contributor

Description

Implements resetting functionality for MainTablePreferences following the pattern established in PR #13894 for WorkspacePreferences.

This PR addresses issue #14413 and contributes to resolving the larger issue #12655 about importing settings not working completely.

Changes

  • Added private default constructor to MainTablePreferences with default values
  • Added getDefault() static method to return a new instance with defaults
  • Added setAll() method to bulk update all preferences from another instance

These methods enable proper resetting of MainTablePreferences during import and clear operations.

Testing

Mandatory Checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (not applicable - preference class pattern)
  • [/] I added screenshots in the PR description (not applicable - backend changes)
  • [/] I described the change in CHANGELOG.md (part of parent issue Implement resetting for one preference #14400)
  • I checked the user documentation: no changes needed for this backend implementation

@jabref-machine
Copy link
Collaborator

You have removed the "Mandatory Checks" section from your pull request description. Please adhere to our pull request template.

@jabref-machine
Copy link
Collaborator

Note that your PR will not be reviewed/accepted until you have gone through the mandatory checks in the description and marked each of them them exactly in the format of [x] (done), [ ] (not done yet) or [/] (not applicable).

@jabref-machine
Copy link
Collaborator

JUnit tests of jablib are failing. You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. To see the test output, locate "Source Code Tests / Unit tests (pull_request)" and click on it.

You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.

@subhramit
Copy link
Member

Code doesn't build, probably an ai-generated attempt.
Mandatory checks have also been modified.
Closing.

@subhramit subhramit closed this Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants