-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Remove obsolete dependency #14433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete dependency #14433
Conversation
.jbang/JabLsLauncher.java
Outdated
| //DEPS org.tinylog:tinylog-impl:2.7.0 | ||
| //DEPS com.github.ben-manes.caffeine:caffeine:3.2.3 | ||
| //DEPS org.apache.commons:commons-lang3:3.20.0 | ||
| //DEPS tools.jackson.core:jackson-core:3.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need the annotations for stuff like @JSON...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I not really get why, but I needed to re-add.
But I could remove other dependencies as they should come in via jablib transitive dependencies.
palukku
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move fast :)
Follow-up to #14259
Refs https://github.com/FasterXML/jackson/blob/main/jackson3/MIGRATING_TO_JACKSON_3.md
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)