Skip to content

Minor refinements on Consistency Check #13771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2025
Merged

Minor refinements on Consistency Check #13771

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82365eb
Use vanilla hashset
subhramit Aug 27, 2025
8d7a844
Merge branch 'main' into quick-refinements
subhramit Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions jablib/src/main/java/org/jabref/logic/quality/consistency/BibliographyConsistencyCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ public Result check(BibDatabaseContext bibContext, BiConsumer<Integer, Integer>
entryTypeDefinitions = BibtexEntryTypeDefinitions.ALL;
}

// Use LinkedHashMap to preserve the order of Bib*EntryTypeDefinitions.ALL
// Use LinkedHashMap to preserve the order of Bib(tex|latex)EntryTypeDefinitions.ALL
Map<EntryType, EntryTypeResult> resultMap = new LinkedHashMap<>();

int counter = 0;
Expand Down Expand Up @@ -195,7 +195,7 @@ private static void collectEntriesIntoMaps(BibDatabaseContext bibContext, Map<En
}

entryTypeToEntriesMap
.computeIfAbsent(entryType, _ -> new java.util.LinkedHashSet<>())
.computeIfAbsent(entryType, _ -> new HashSet<>())
Copy link
Member

@Siedlerchr Siedlerchr Aug 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LInkedHashSet preserves insertion order

Copy link
Member Author

@subhramit subhramit Aug 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but isn't a sort happening later anyway at

jabref/jablib/src/main/java/org/jabref/logic/quality/consistency/BibliographyConsistencyCheck.java

Line 164 in 5f30d81

List<BibEntry> sortedEntries = filterAndSortEntriesWithFieldDifferences(entries, differingFields, requiredFields);

Copy link
Member

@koppor koppor Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LInkedHashSet preserves insertion order

Therefore, I a) read the code, thought through and b) relied in the test cases (which I also checked)

.add(entry);
}
}
Expand Down