Skip to content

Conversation

@palukku
Copy link
Member

@palukku palukku commented Jul 3, 2025

Follow up #13185 and #13187 (comment)

Closes palukku#5

Steps to test

You can test the simple-json format by using this command:
curl http://localhost:23119/better-bibtex/cayw?format=simple-json

for biblatex (which is the default format) you can use this and change the command (defaults to autocite)
curl http://localhost:23119/better-bibtex/cayw?format=biblatex&command=notautocite

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • [/] Screenshots added in PR description (if change is visible to the user)
  • [/] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [/] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

koppor
koppor previously approved these changes Jul 3, 2025
@koppor koppor enabled auto-merge July 3, 2025 20:55
auto-merge was automatically disabled July 3, 2025 20:58

Head branch was pushed to by a user without write access

public class CAYWEntry {

private final T value;
private final BibEntry bibEntry;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The field lacks proper nullability annotation (@nullable or @nonnull) which is required for public methods and fields to clearly indicate null handling behavior.

@koppor koppor enabled auto-merge July 3, 2025 21:04
@jabref-machine

This comment was marked as resolved.

@trag-bot
Copy link

trag-bot bot commented Jul 3, 2025

@trag-bot didn't find any issues in the code! ✅✨

@jabref-machine
Copy link
Collaborator

Your code currently does not meet JabRef's code guidelines. We use OpenRewrite to ensure "modern" Java coding practices. You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. To see the test output, locate "Tests / OpenRewrite (pull_request)" and click on it.

The issues found can be automatically fixed. Please execute the gradle task rewriteRun from the rewrite group of the Gradle Tool window in IntelliJ, then check the results, commit, and push.

@koppor koppor added this pull request to the merge queue Jul 3, 2025
Merged via the queue into JabRef:main with commit a011277 Jul 3, 2025
1 check passed
@palukku palukku mentioned this pull request Jul 23, 2025
6 tasks
@subhramit subhramit added the component: cite-as-you-write cayw (similar to better-bibtex for Zotero) label Aug 16, 2025
@palukku palukku changed the title Refine CAYW Endpoint Feat: Refine and add more options to the CAYW endpoint Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: cite-as-you-write cayw (similar to better-bibtex for Zotero) project: gsoc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement json closer to BBT

4 participants