-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Refine PR Template #13316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine PR Template #13316
Conversation
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| <!-- (Replace this paragraph.) --> | ||
|
|
||
| <!-- YOU HAVE TO MODIFY THE ABOVE TEXT FIT YOUR PR. OTHERWISE, YOUR PR WILL BE CLOSED WITHOUT FURTHER COMMENT. --> | ||
| <!-- LINK THE ISSUE WITH THE "Closes" KEYWORD. Example: Closes (link) OR Closes #12345 --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last - I think we can move this line (14) above line 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, was there any reason why we shifted this here? Some contributor messing up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Claim: GitHub App on android shows exactly the first characters:
Did you get a notificatoin for https://github.com/JabRef/jabref-issue-melting-pot/pull/960 and can check?
I did not find any "strange" notification; but I think, I read all of them.
(We updated it at #13188)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was done with GitHub app recently when I realized it ate away context from a link (e.g. someone wanted to point out to a comment or review, and it would just open the PR or issue)
I will install and try
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So are we shifting line 14?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So are we shifting line 14?
Maybe to line 2 instead of 1? So that it is near the "Closes _____" and if it displays the first 3 characters that won't affect as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I shifted. See if this is fine (b3455d3)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will reshift as soon as I have a screenshot (I hope there will be never one)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I shifted to line 2, not line 1, so the first 3 characters would still be "Clo" (if we are talking about the same thing) - so you should not face issues because of the comment at least
|
Ah the order of comments got messed up, sorry |
|
Okay, I don't think we can make it better than this |
Co-authored-by: Subhramit Basu <[email protected]>
Co-authored-by: Subhramit Basu <[email protected]>
|
@trag-bot didn't find any issues in the code! ✅✨ |

Trying to use backticks as markers for replacement. I think,
<!-- -->,{{...}},«...»will cause more confusion.Rendering if nothing is changed
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)