Skip to content

Conversation

@Siedlerchr
Copy link
Member

Closes #_____

In about one to three sentences, describe the changes you have made: what, where, why, ...

Steps to test

Describe how reviewers can test this fix/feature. Ideally, think of how you would guide a beginner user of Jabef to try out your change.
You can add screenshots or videos (using Loom or by just adding .mp4 files).

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [.] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [.] Tests created for changes (if applicable)
  • [.] Manually tested changed features in running JabRef (always required)
  • [.] Screenshots added in PR description (if change is visible to the user)
  • [.] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [.] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the automerge PR is tagged with that label will be merged if workflows are green label Jun 9, 2025
@Siedlerchr Siedlerchr enabled auto-merge June 9, 2025 11:26
@trag-bot
Copy link

trag-bot bot commented Jun 9, 2025

@trag-bot didn't find any issues in the code! ✅✨

@Siedlerchr Siedlerchr added this pull request to the merge queue Jun 9, 2025
Merged via the queue into main with commit 4da1a4a Jun 9, 2025
2 checks passed
@Siedlerchr Siedlerchr deleted the Siedlerchr-patch-1 branch June 9, 2025 11:56
@koppor
Copy link
Member

koppor commented Jun 10, 2025

Why is this necessary? The action successfully ran without a java installation -> https://github.com/JabRef/jabref/actions/runs/15384215061/job/43279810420

@Siedlerchr
Copy link
Member Author

Siedlerchr commented Jun 10, 2025

No, the action did not run successfully without the set up: #13281 (comment)
Original run: https://github.com/JabRef/jabref/actions/runs/15527196491/job/43709039773

@koppor
Copy link
Member

koppor commented Jun 10, 2025

No, the action did not run successfully without the set up: #13281 (comment)
Original run: https://github.com/JabRef/jabref/actions/runs/15527196491/job/43709039773

The link goes to a different workflow, not the gradle update

@koppor
Copy link
Member

koppor commented Jun 10, 2025

@Siedlerchr
Copy link
Member Author

Odd. Then why did the build not work?

@koppor
Copy link
Member

koppor commented Jun 10, 2025

Odd. Then why did the build not work?

GitHub actions hickup. And the binaries workflow had issues. Not the gradle update aciton workflow. These are two different files!

I will file a PR as soon as I have battery power again.

@koppor koppor mentioned this pull request Jun 10, 2025
1 task
@koppor
Copy link
Member

koppor commented Jun 10, 2025

All binaries failed:

image

I think, gradle server rejected calls:

Resource missing. [HTTP HEAD: https://plugins.gradle.org/m2/org/gradle/toolchains/foojay-resolver-convention/org.gradle.toolchains.foojay-resolver-convention.gradle.plugin/1.0.0/org.gradle.toolchains.foojay-resolver-convention.gradle.plugin-1.0.0.jar]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge PR is tagged with that label will be merged if workflows are green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants