-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Improve utf8 detection #12342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Improve utf8 detection #12342
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d8b30e0 to
bf50b99
Compare
bf50b99 to
0714b66
Compare
koppor
reviewed
Dec 30, 2024
Contributor
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
|
|
||
| ### Fixed | ||
|
|
||
| - We fixed an issue where a bib file with UFF-8 charset was wrongly loaded with a different charset [forum#5369](https://discourse.jabref.org/t/jabref-5-15-opens-bib-files-with-shift-jis-encoding-instead-of-utf-8/5369/) |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| - We fixed an issue where a bib file with UFF-8 charset was wrongly loaded with a different charset [forum#5369](https://discourse.jabref.org/t/jabref-5-15-opens-bib-files-with-shift-jis-encoding-instead-of-utf-8/5369/) | |
| - We fixed an issue where a bibtex file with UTF-8 charset was wrongly loaded with a different charset [forum#5369](https://discourse.jabref.org/t/jabref-5-15-opens-bib-files-with-shift-jis-encoding-instead-of-utf-8/5369/) |
HoussemNasri
approved these changes
Dec 30, 2024
Siedlerchr
added a commit
that referenced
this pull request
Jan 8, 2025
* upstream/main: Update abbrv.jabref.org (#12365) Bump buildres/abbrv.jabref.org from `78e1b08` to `c202741` (#12363) Bump org.beryx.jlink from 3.1.0-rc-1 to 3.1.1 (#12362) Bump tech.units:indriya from 2.2.1 to 2.2.2 (#12361) Bump com.dlsc.gemsfx:gemsfx from 2.80.0 to 2.81.0 (#12360) Bump org.mariadb.jdbc:mariadb-java-client from 2.7.9 to 2.7.12 (#12359) Bump org.mockito:mockito-core from 5.14.2 to 5.15.2 (#12358) Fix content not correctly parsed at pdf content importer (#12338) Bump de.undercouch:citeproc-java from 3.1.0 to 3.2.0 (#12347) Bump org.openrewrite.rewrite from 6.29.0 to 6.29.2 (#12345) Improve utf8 detection (#12342) Bump org.fxmisc.richtext:richtextfx from 0.11.3 to 0.11.4 (#12346) Bump ai.djl:bom from 0.30.0 to 0.31.1 (#12344) Bump com.puppycrawl.tools:checkstyle from 10.21.0 to 10.21.1 (#12343)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://discourse.jabref.org/t/jabref-5-15-opens-bib-files-with-shift-jis-encoding-instead-of-utf-8/5369/
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)