Generate embeddings and summaries of a group in context menu #11832

InAnYan · 2024-09-25T20:59:55Z

Partially solves https://github.com/JabRef/jabref-issue-melting-pot/issues/546

Mandatory checks

~~- [ ] Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)~~
~~- [ ] Tests created for changes (if applicable)~~

Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

github-actions

Your code currently does not meet JabRef's code guidelines.
We use OpenRewrite to ensure "modern" Java coding practices.
The issues found can be automatically fixed.
Please execute the gradle task rewriteRun, check the results, commit, and push.

You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "OpenRewrite".

src/main/java/org/jabref/gui/actions/StandardActions.java

koppor · 2024-09-29T12:27:33Z

src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java

@@ -386,7 +396,6 @@ public void editGroup(GroupNodeViewModel oldGroup) {
    }

    public void chatWithGroup(GroupNodeViewModel group) {
-        // This should probably be done some other way. Please don't blame, it's just a thing to make it quick and fast.
        if (currentDatabase.isEmpty()) {
            dialogService.showErrorDialogAndWait(Localization.lang("Unable to chat with group"), Localization.lang("No library is selected."));


Is this branch ever it in th execution? Maybe, it can be replaced by a LOGGER.warn statement?

Well, the code really can't proceed without a database.

I don't like that if there is no database, there is no reasonably visible response from the JabRef. Just a LOGGER.warn. Not sure what should I do

What I mean, we could do assert !currentDatabase.isEmpty(). -- Thus: My bet is: This branch is never hit during real use in JabRef.

This creates an additional translation string - therefore I was thinking and worrying.

koppor · 2024-09-29T12:27:45Z

src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java

+        if (currentDatabase.isEmpty()) {
+            dialogService.notify(Localization.lang("Unable to generate embeddings. No library is selected."));
+            return;
+        }


Is this branch ever it in th execution? Maybe, it can be replaced by a LOGGER.warn statement?

See #11832 (comment)

porposal for now. Re-use "Unable to chat" and add a LOGGER.warn with the full message. If user enounters this situation, we will see in the log.

koppor · 2024-09-29T12:27:59Z

src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java

+        if (currentDatabase.isEmpty()) {
+            dialogService.notify(Localization.lang("Unable to generate summaries. No library is selected."));
+            return;
+        }
+


Is this branch ever it in th execution? Maybe, it can be replaced by a LOGGER.warn statement?

See #11832 (comment)

porposal for now. Re-use "Unable to chat" and add a LOGGER.warn with the full message. If user enounters this situation, we will see in the log.

src/main/java/org/jabref/logic/ai/summarization/SummariesService.java

koppor · 2024-09-29T12:30:28Z

src/main/resources/l10n/JabRef_en.properties

+Unable\ to\ generate\ embeddings.\ No\ library\ is\ selected.=Unable to generate embeddings. No library is selected.
+Unable\ to\ generate\ summaries.\ No\ library\ is\ selected.=Unable to generate summaries. No library is selected.


I think, these can be removed (see above) --> logger.warn outputs are not localized.

See #11832 (comment)

These strings should then vanish.

github-actions

Your code currently does not meet JabRef's code guidelines.
We use OpenRewrite to ensure "modern" Java coding practices.
The issues found can be automatically fixed.
Please execute the gradle task rewriteRun, check the results, commit, and push.

You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "OpenRewrite".

InAnYan · 2024-10-03T07:41:34Z

Updated, but can you tell me what should I do with that branch without database?

Leave as is or use LOGGER instead of a dialogService?

InAnYan · 2024-10-06T10:32:19Z

I put an assert there)

…te-ai-actions

koppor

micro comment.

koppor · 2024-10-06T11:36:22Z

src/main/java/org/jabref/logic/ai/summarization/SummariesService.java

@@ -59,6 +59,12 @@ public SummariesService(AiPreferences aiPreferences,
        this.taskExecutor = taskExecutor;
    }

+    /**
+     * Start generating summary of a {@link BibEntry}, if it was already generated.


I think, there is something missing before "if it was"

Suggested change

* Start generating summary of a {@link BibEntry}, if it was already generated.

* Start generating summary of a {@link BibEntry}, independent of whether if it was already generated.

Oops, it should mean: if it wasn't

If it wasn't, it will start summarization task and put a ProcessingInfo in the map.

If it is generating, it will return current ProcessingInfo

Oops, it should mean: if it wasn't

Just reword and commit 😅

# Conflicts: # src/main/java/org/jabref/gui/groups/GroupTreeView.java # src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java # src/main/java/org/jabref/gui/sidepane/SidePaneContentFactory.java # src/main/java/org/jabref/logic/ai/summarization/SummariesService.java # src/main/resources/l10n/JabRef_en.properties # src/test/java/org/jabref/gui/groups/GroupTreeViewModelTest.java

Generate embeddings and summaries of a group in context menu

11c8587

github-actions bot reviewed Sep 25, 2024

View reviewed changes

koppor requested changes Sep 29, 2024

View reviewed changes

InAnYan added 2 commits October 3, 2024 10:24

Merge branch 'upstream-main' into generate-ai-actions

29d7d75

Fixes from code review

0d439f1

github-actions bot reviewed Oct 3, 2024

View reviewed changes

Fix checkers

245da92

InAnYan requested a review from koppor October 3, 2024 07:41

Fix from code review

1a17456

InAnYan added 3 commits October 6, 2024 14:08

Merge branch 'main' into generate-ai-actions

76e0053

Fix checkers

7a8399a

Merge remote-tracking branch 'origin/generate-ai-actions' into genera…

7ec5b7a

…te-ai-actions

koppor requested changes Oct 6, 2024

View reviewed changes

koppor enabled auto-merge October 6, 2024 11:37

InAnYan added 2 commits October 6, 2024 15:33

Merge with main

bcb0d34

koppor approved these changes Oct 6, 2024

View reviewed changes

koppor added this pull request to the merge queue Oct 6, 2024

Merged via the queue into JabRef:main with commit b6efdee Oct 6, 2024
23 checks passed

koppor deleted the generate-ai-actions branch October 6, 2024 15:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generate embeddings and summaries of a group in context menu #11832

Generate embeddings and summaries of a group in context menu #11832

InAnYan commented Sep 25, 2024

github-actions bot left a comment

koppor Sep 29, 2024

InAnYan Oct 3, 2024

koppor Oct 4, 2024 •

edited

Loading

koppor Sep 29, 2024

InAnYan Oct 3, 2024

koppor Oct 4, 2024

koppor Sep 29, 2024

InAnYan Oct 3, 2024

koppor Oct 4, 2024

koppor Sep 29, 2024

InAnYan Oct 3, 2024

koppor Oct 4, 2024

github-actions bot left a comment

InAnYan commented Oct 3, 2024

InAnYan commented Oct 6, 2024

koppor left a comment

koppor Oct 6, 2024

InAnYan Oct 6, 2024

InAnYan Oct 6, 2024

koppor Oct 6, 2024

		Unable\ to\ generate\ embeddings.\ No\ library\ is\ selected.=Unable to generate embeddings. No library is selected.
		Unable\ to\ generate\ summaries.\ No\ library\ is\ selected.=Unable to generate summaries. No library is selected.

	* Start generating summary of a {@link BibEntry}, if it was already generated.
	* Start generating summary of a {@link BibEntry}, independent of whether if it was already generated.

Generate embeddings and summaries of a group in context menu #11832

Generate embeddings and summaries of a group in context menu #11832

Conversation

InAnYan commented Sep 25, 2024

Mandatory checks

github-actions bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

koppor Oct 4, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

InAnYan commented Oct 3, 2024

InAnYan commented Oct 6, 2024

koppor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

koppor Oct 4, 2024 •

edited

Loading