Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine parsing format of CSL reference marks #11720

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

subhramit
Copy link
Member

@subhramit subhramit commented Sep 7, 2024

Follow-up to: #11712

  • Use more strict regex to exactly match the format, disallow multiple whitespaces, disallow absence of unique ID, etc.
  • A lot of code I wrote for CSL4LibreOffice - E [Add re-distribution of numeric CSL citations] #11712 may seem like black-magic, as the fix was needed as soon as possible. I will slowly be documenting the code to aid this. Some JavaDoc is added in this PR as well.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added this pull request to the merge queue Sep 7, 2024
Merged via the queue into JabRef:main with commit 2b55ddb Sep 7, 2024
24 checks passed
@Siedlerchr Siedlerchr deleted the csl-maintenance branch September 7, 2024 17:57
leaf-soba pushed a commit to leaf-soba/jabref that referenced this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants