-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Do not ask again" for empty entry confirmation in JabRef #8296
Comments
@ruoyu-qian. If this is ticked, will Jabref remember the action (delete/no delete) that was chosen in the checkbox and do the same thing whenever Jabref will be closed, or will it just cancel the dialogue box from ever emerging again? |
@ThiloteE Sorry, you were right! My previous implementation would not remember user's choice. I made some changes. It now should remember the action (delete/keep) that was chosen when the user checked "do not ask again". |
I was just curious, but thaaaaaaanks 😁 |
Hi, I am interested to fix the issues that have been mentioned in #8296 and #8297. Solution for #8296: I am planning to look into issue in #8297 that causes a tab not to close properly once feature added for #8296. |
Thanks for the interest, that sounds good. |
Dunno... Maybe EntryEditorPreferences? |
Hi, I am working on issues #8297 about tab unable to close if a dialog box has been closed/cancelled.
Questions
|
@LIM0000 thank you for the research and amount of thought you have put into this. I would ask you to open a pull request so that the technical details can be discussed over there.
There are some reasons for this:
|
@LIM0000 Thanks again for the investigation. Tricky thing. So I guess the EventHandler is no longer called when you click again because the tab is assumed to be closed? |
@ThiloteE @Siedlerchr We discussed in the last dev call. Should we change the requirement to remove the dialog completely and just always delete empty entries? Empty entries only have the entry type as information. I think, the information "Oh, I wanted to create an artcile" is not really helpful for a user, is it? |
I wouldn't manipulate the bib without asking the user. There is always an edge case. |
This is supersed by the decsion #8645 (comment). We a) add a checker and b) genreated the |
Following up on #8096
do not ask for this kind of issue again
for empty entry confirmationsOriginally posted by @ThiloteE in #8096 (comment)
The text was updated successfully, but these errors were encountered: