Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a subgroup: a warning should not close the window #6066

Closed
mlep opened this issue Mar 5, 2020 · 1 comment · Fixed by #6110
Closed

Add a subgroup: a warning should not close the window #6066

mlep opened this issue Mar 5, 2020 · 1 comment · Fixed by #6110
Assignees
@stefan-kolb
Labels
component: groups component: ui good first issue An issue intended for project-newcomers. Varies in difficulty.
Milestone
v5.1

Comments

@mlep
Copy link
Contributor

mlep commented Mar 5, 2020

JabRef 5.0-beta.532--2020-03-04--8111707
Linux 4.9.0-12-amd64 amd64
Java 13.0.2

While adding a subgroup, if a warning is displayed, the "add subgroup" window is closed.

Steps to reproduce the behavior:

  1. In the group interface, right click and select "Add subgroup". This opens a window entitled "Add subgroup"
  2. In this window, add a text in the description field. And DO NOT enter a group name.
  3. Click on OK

==> An error window appears, stating (rightfully) that "Please enter a name for the group". Click on OK (no other choice). This causes the window "Add subgroup" to disappear.
Expected behavior: leave open the window "Add subgroup", so that I can enter the name of the group.
@tobiasdiez tobiasdiez added good first issue An issue intended for project-newcomers. Varies in difficulty. component: groups component: ui labels Mar 6, 2020
@stefan-kolb
Copy link
Member

stefan-kolb commented Mar 13, 2020 •
edited
Loading

Should be fixed by #6110

@stefan-kolb stefan-kolb added this to the v5.1 milestone Mar 13, 2020
@stefan-kolb stefan-kolb mentioned this issue Mar 14, 2020
Merged
4 tasks
@stefan-kolb stefan-kolb self-assigned this Mar 14, 2020
koppor pushed a commit that referenced this issue Sep 1, 2022
Squashed 'buildres/csl/csl-styles/' changes from c750b6e..8d69f16
c15cec8 
8d69f16 Create university-of-hull-harvard.csl (#6146)
139dfdd Create current organic synthesis.csl (#6139)
bb006c8 Update acta-universitatis-agriculturae-sueciae.csl (#6143)
5815da0 Create food-science-and-biotechnology.csl (#6132)
2702a7c Update harvard-university-for-the-creative-arts.csl (#6104)
ef34543 Update economic-geology.csl (#6128)
0adcd30 Bump mathieudutour/github-tag-action from 5.6 to 6.0 (#6141)
3c36e97 Create universite-du-quebec-a-montreal-prenoms.csl (#6073)
415bc05 Bump softprops/action-gh-release from 0.1.14 to 1 (#6142)
ae8c5e4 Create politique-europeenne.csl (#6074)
09cbc09 Update cell-numeric-superscript.csl (#6188)
6ee1ace Update avian-conservation-and-ecology.csl (#6191)
cb5c43f Update harvard-anglia-ruskin-university.csl (#6189)
5c4f4c0 Create anais-da-academia-brasileira-de-ciencias.csl (#6066)
a60dfe9 Update cardiff-university-harvard.csl (#6190)
999a45c Create sociologia-urbana-e-rurale.csl (#6042)
1bc9d62 Bluebook (#6183)
a4f2a72 Oxford Brookes (#6182)
88df8d5 Delete harvard-cardiff-university-old.csl (#6180)
b9302fd Update APA styles for "event" macro (#6174)
d4daec6 remove DOI for printed articles organizational-studies.csl (#6176)
acfc620 Create liver-transplantation.csl (#6167)
129a775 Change "event" to "event-title" (#6164)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 8d69f16
@koppor koppor moved this to Done in Prioritization Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefan-kolb stefan-kolb

Labels
component: groups component: ui good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Prioritization
Archived in project
Milestone
v5.1
Development

Successfully merging a pull request may close this issue.

Groups: Searching for keywords field mandatory value not checked JabRef/jabref
3 participants
@stefan-kolb @tobiasdiez @mlep