Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several variables are not passed to the NSIS installer #202

Closed
stefan-kolb opened this issue Oct 2, 2015 · 3 comments
Closed

Several variables are not passed to the NSIS installer #202

stefan-kolb opened this issue Oct 2, 2015 · 3 comments

Comments

@stefan-kolb
Copy link
Member

e.g. ${COMPANY}, ${URL}, ${REGKEY}
This might cause problems with uninstallation?!

We just pass VERSION in build.gradle:
commandLine project.ext.nsisExec, "-DVERSION=${version}", "${projectDir}/buildres/nsis/setup.nsi"

@matthiasgeiger
Copy link
Member

uninstallation works for 2.11b4

@stefan-kolb
Copy link
Member Author

Found the definitions, my bad!

@koppor
Copy link
Member

koppor commented Oct 2, 2015

Maybe this should be commented somehow somewhere that someone else doesn't fall in the same trap? Maybe https://github.com/JabRef/jabref/wiki/Code-Howtos?

github-actions bot pushed a commit that referenced this issue Feb 26, 2020
…73af4a3fe

d73af4a3fe Bump nokogiri from 1.10.7 to 1.10.8 (#202)

git-subtree-dir: src/main/resources/csl-locales
git-subtree-split: d73af4a3fe056b5cce8e927446fc9bbffdeace22
github-actions bot pushed a commit to systemoperator/jabref that referenced this issue Feb 26, 2020
…73af4a3fe

d73af4a3fe Bump nokogiri from 1.10.7 to 1.10.8 (JabRef#202)

git-subtree-dir: src/main/resources/csl-locales
git-subtree-split: d73af4a3fe056b5cce8e927446fc9bbffdeace22
github-actions bot referenced this issue in calixtus/jabref Feb 27, 2020
…73af4a3fe

d73af4a3fe Bump nokogiri from 1.10.7 to 1.10.8 (#202)

git-subtree-dir: src/main/resources/csl-locales
git-subtree-split: d73af4a3fe056b5cce8e927446fc9bbffdeace22
github-actions bot pushed a commit to CaptainDaVinci/jabref that referenced this issue Mar 1, 2020
…b94bf9fac

2b94bf9fac Fix markdown lint error "[no-literal-urls] Don’t use literal URLs without angle brackets" (JabRef#203)
d73af4a3fe Bump nokogiri from 1.10.7 to 1.10.8 (JabRef#202)

git-subtree-dir: src/main/resources/csl-locales
git-subtree-split: 2b94bf9fac34a2f6b73f4d320144e5c0cb8a05bc
github-actions bot pushed a commit to NikodemKch/jabref-1 that referenced this issue Mar 1, 2020
…b94bf9fac

2b94bf9fac Fix markdown lint error "[no-literal-urls] Don’t use literal URLs without angle brackets" (JabRef#203)
d73af4a3fe Bump nokogiri from 1.10.7 to 1.10.8 (JabRef#202)

git-subtree-dir: src/main/resources/csl-locales
git-subtree-split: 2b94bf9fac34a2f6b73f4d320144e5c0cb8a05bc
github-actions bot pushed a commit to abepolk/jabref that referenced this issue Mar 1, 2020
…b94bf9fac

2b94bf9fac Fix markdown lint error "[no-literal-urls] Don’t use literal URLs without angle brackets" (JabRef#203)
d73af4a3fe Bump nokogiri from 1.10.7 to 1.10.8 (JabRef#202)

git-subtree-dir: src/main/resources/csl-locales
git-subtree-split: 2b94bf9fac34a2f6b73f4d320144e5c0cb8a05bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants