This repository was archived by the owner on Aug 25, 2026. It is now read-only.
fix: retry Codex secondmate sends - #32
Merged
JTInventory merged 2 commits intoJul 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Ship a narrow Firstmate fix so fm-send can submit ordinary marked messages to Codex secondmate windows without leaving typed text in the composer.
What Changed
fm-sendnow retries Enter submission for Codex secondmate panes when marked text remains pending, so marked messages do not stay in the composer.Risk Assessment
✅ Low: Captain, the change is narrowly scoped to one Codex secondmate retry path and preserves the shared submit core plus existing crewmate/non-Codex behavior.
Testing
Captain, the supplied full-suite baseline was already green; I reran the focused fm-send retry, popup-settle, marker, and settle tests, then captured a stubbed tmux evidence transcript showing the marked Codex secondmate message typed once, three generic Enter attempts leaving the composer pending, and one delayed final Enter clearing it. The worktree was clean after testing.
Evidence: Codex secondmate delayed submit evidence
Evidence: Focused retry test transcript
ok - fm-send: marked Codex secondmate text gets one delayed final Enter ok - fm-send: Codex crewmates keep the generic submit retry behavior ok - fm-send: non-Codex secondmates keep the generic submit retry behaviorPipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
bash bin/fm-no-mistakes-pr-target-guard.sh || exit 1; command -v tmux >/dev/null || { echo "tmux is required for e2e tests" >&2; exit 1; }; tmux -V; rc=0; for t in tests/*.test.sh; do echo "== $t =="; bash "$t" || rc=1; done; exit "$rc"Baseline reported by runner as already successful:bash bin/fm-no-mistakes-pr-target-guard.sh || exit 1; command -v tmux >/dev/null || { echo "tmux is required for e2e tests" >&2; exit 1; }; tmux -V; rc=0; for t in tests/*.test.sh; do echo "== $t =="; bash "$t" || rc=1; done; exit "$rc".bash tests/fm-send-codex-secondmate-submit-retry.test.sh && bash tests/fm-send-popup-settle.test.sh && bash tests/fm-send-secondmate-marker.test.sh && bash tests/fm-send-settle.test.shStubbed tmux evidence run ofbin/fm-send.sh fm-target 'check the queue'withharness=codex,kind=secondmate,FM_SEND_RETRIES=3, and composer clearing only on the fourth Enter.bash tests/fm-send-codex-secondmate-submit-retry.test.sh > /tmp/no-mistakes-evidence/01KWF0QQ8M44HF44GNK72014RY/fm-send-codex-secondmate-submit-retry-test.log 2>&1git status --short✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.