This repository was archived by the owner on Aug 25, 2026. It is now read-only.
feat: replay inactive terminal outcomes - #100
Merged
Merged
Conversation
…ts, and bounded scans
…e acknowledgement
…cher acknowledgement
added 28 commits
August 16, 2026 20:59
…llow retry writes
…state attribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
JT-native inactive terminal outcome replay from upstream kunchenguid#2167: durable incarnation-and-snapshot receipts and one drain-owned wake for direct done/failed crews, bounded home-local scans, strict secondmate parent correlation, focused JT tests; reporting only, never teardown, PR mutation, CAPTAIN/default, chat scrape, or forge/network calls.
What Changed
ship/scoutchildren, using authoritative terminal state plus incarnation/run-step evidence to create atomicfm-jt-terminal-outcome.v1receipts.corr=validation.Risk Assessment
✅ Low: Captain, the prior process-group cleanup issue is corrected before reaping, and the full changed source review found no additional material source-verifiable risk or intent contradiction.
Testing
The preconfigured baseline had passed, was rerun successfully, and the complete targeted inactive-outcome suite passed end to end with CLI evidence for durable replay, bounded scans, strict secondmate correlation, and fail-closed behavior. No UI surface was involved, so screenshot evidence was not applicable.
/tmp/no-mistakes-evidence/01M079M91TXRXJJGD87TPA96JJ3/inactive-outcome-full-final-13.log)Evidence: Required baseline batch
Evidence: Done/failed replay evidence
Evidence: Bounded receipt maintenance
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
🔧 **Review** - 1 issue found → auto-fixed ✅
bin/fm-run-step-bridge.sh:351- Normal completion reaps$childbeforerun_axi_stop_groupsignals the process group by that PID. If the PID is reused, cleanup can TERM/KILL an unrelated process group. Stop and verify the group before reaping the leader, or validate its identity before signaling.🔧 Fix: Hardened bridge cleanup against PID reuse
✅ Re-checked - no issues remain.
🔧 **Test** - 1 issue found → auto-fixed (2) ✅
bash tests/fm-worker-isolation.test.sh && bash tests/fm-watch-session.test.sh && bash tests/fm-slot-occupant-proof.test.sh && FM_TEARDOWN_TEST_FOCUS=s1 bash tests/fm-teardown.test.sh🔧 Fix: Preserved worker declaration before run-binding PATH injection
1 error still open:
bash tests/fm-worker-isolation.test.sh && bash tests/fm-watch-session.test.sh && bash tests/fm-slot-occupant-proof.test.sh && FM_TEARDOWN_TEST_FOCUS=s1 bash tests/fm-teardown.test.sh🔧 Fix: Fixed optional worktree parsing; focused teardown tests pass
✅ Re-checked - no issues remain.
bash tests/fm-worker-isolation.test.sh && bash tests/fm-watch-session.test.sh && bash tests/fm-slot-occupant-proof.test.sh && FM_TEARDOWN_TEST_FOCUS=s1 bash tests/fm-teardown.test.shbash tests/fm-inactive-outcome.test.shbash tests/fm-worker-isolation.test.sh && bash tests/fm-watch-session.test.sh && bash tests/fm-slot-occupant-proof.test.sh && FM_TEARDOWN_TEST_FOCUS=s1 bash tests/fm-teardown.test.shFM_INACTIVE_TEST_ONLY=test_done_and_failed_are_replayed_once bash tests/fm-inactive-outcome.test.shFM_INACTIVE_TEST_ONLY=test_pending_receipt_republish_is_bounded bash tests/fm-inactive-outcome.test.shFM_INACTIVE_TEST_ONLY=test_postpublication_uncertainty_is_not_replayed bash tests/fm-inactive-outcome.test.sh✅ **Document** - passed
✅ No issues found.
🔧 **Lint** - 1 issue found → auto-fixed (2) ✅
🔧 Fix: Captain: fix inactive reconciliation ShellCheck warnings
1 warning still open:
🔧 Fix: Fix ShellCheck warnings across scripts and fixtures
✅ Re-checked - no issues remain.
✅ **Push** - passed
✅ No issues found.