Added support for paged results #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To remove ambiguity as to their function.
Previously it returned the list of zones, but it needs to return the whole response to expose access to the pagination information.
Previously it returned the list of DNS records, but it needs to return the whole response to expose access to the pagination information.
These can involve multiple paged requests.
JSkimming
added a commit
that referenced
this pull request
Sep 3, 2015
Added support for paged results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods like List zones and List DNS Records have a maximum number of entries they will return in a single request, and use paging to return more records.
To handle this the library now exposes the paged results in the API, which has resulted in breaking change.
Helper methods
GetAll[Zones|DnsRecords]Asyncare also provided that still return the complete list and will make multiple requests if necessary.