tests passing, linted, and prittified, with all bugfixes from forks / contributors #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update touch cookie to avoid [email protected]: ReDoS vulnerability parsing Set-Cookie https://nodesecurity.io/advisories/130
As far as I can tell the netscape cookie file format does not specify that the cookie name/value should be URL encoded. Doing so breaks compatibility with for instance wget when using base64 encoded cookie values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New, Currently Maintained fork
For those finding this issue - if these changes are not accepted - please use the fork at @root/file-cookie-store.