-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add target option #69
Conversation
@razor-x can you describe how Ideally I'd hope that we only need |
@mcous Yes, I guess the arg name should be One could argue that the current arg Anyway, the important thing is to have a way to pass in the first (and only) argument to
|
I've been working my way through the code in the main branch, and I'm starting to have a few thoughts about the existing
What do you think of these points? To brainstorm something:
|
Agreed. Especially since working directory is supported by GitHub actions, probably best not to mess with it.
Good point, the way I was using this I was assuming the correct
That looks like the right logic to me. And yes, we should extract the |
@mcous Closing this one since with the new proposal we would not be adding a new input but changing the behavior of the exiting Thanks for bringing this repo back from the brink, the updates coming in look great! I am really busy recently, and I can try to get back to opening a new PR with those changes, but if you get to it first it's ok with me! Moved to issue: #81 |
Allows passing the first argument to npm publish as a new option:
target
.This is particularly useful if building the packing or installing dependencies takes a lot of time but is available as an artifact in an earlier job.
Build is passing when rebased off this PR: #68
Closes #59