Skip to content

fix(windows): allow spawning npm cli on windows #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2024
Merged

fix(windows): allow spawning npm cli on windows #199

merged 1 commit into from
Jun 1, 2024

Conversation

@mcous
Copy link
Member

@mcous mcous commented Jun 1, 2024 •
edited
Loading

  • Pass shell: true to child_process.spawn in Windows.
  • Add additional validation to the tag option and package name.

Fixes #198

@mcous mcous force-pushed the fix-windows-cli branch from 6685d5c to cdd51f2 Compare June 1, 2024 18:53
@mcous mcous marked this pull request as ready for review June 1, 2024 18:57
@mcous mcous merged commit f45e793 into main Jun 1, 2024
@mcous mcous deleted the fix-windows-cli branch June 1, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Not working on Windows with latest version of Node.js

2 participants

@mcous