feat: allow --ignore-scripts to be disabled, if needed #102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Taking a look back at closed issues in this repo, I've seen some external issues linked back that indicated folks have been running into issues with adding
--ignore-scripts
to allnpm
calls. In hindsight, setting it by default, rather quietly, probably needed a little more consideration.But it's where we're at now, so let's make the most of it! This PR adds an
ignore-scripts
input to the action (and CLI and lib) that can be set tofalse
, for users who rely on lifecycle scripts for publish and understand the security implications.