Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If tag isn't specified, fall back to publishConfig #36

Closed
rikoe opened this issue Apr 15, 2021 · 0 comments · Fixed by #84
Closed

If tag isn't specified, fall back to publishConfig #36

rikoe opened this issue Apr 15, 2021 · 0 comments · Fixed by #84
Labels
enhancement New feature or request

Comments

@rikoe
Copy link

rikoe commented Apr 15, 2021

It would be great if the action can actually check if a tag is specified as part of publishConfig in package.json, otherwise whenever wanting to switch between @next or @latest for tags, I have to directly modify the github workflow file itself, which is kind of hidden away and easily forgotten.

Also, it is more correct to use the publishConfig fallback in package.json for tag, instead of hard-coding to latest if not specified in GitHub action options.
@mcous mcous added the enhancement New feature or request label Apr 7, 2023
@mcous mcous mentioned this issue Apr 14, 2023
Merged
mcous added a commit that referenced this issue Apr 20, 2023
@mcous
Rewrite internals for v2 release (#83)
c5f37b9 
Addresses #15, #35, #36, #47, #51, and #59
@mcous mcous mentioned this issue Apr 20, 2023
Merged
@mcous mcous closed this as completed in #84 Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to version 2 JS-DevTools/npm-publish
2 participants
@mcous @rikoe