Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing include #35

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Add missing include #35

merged 1 commit into from
Sep 2, 2024

Conversation

Thomas1664
Copy link
Contributor

I got the following error on Apple Clang 15:

[1/17] /Library/Developer/CommandLineTools/usr/bin/c++  -I/Users/vagrant/Data/buildtrees/ctbench/src/v1.3.3-f96a0799ba.clean/grapher/include -isystem /Users/vagrant/Data/installed/x64-osx/include -fPIC -g -std=gnu++20 -arch x86_64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX14.0.sdk -DJSON_NOEXCEPTION -Wall -Wextra -Werror -Wnull-dereference -Wold-style-cast -Wdouble-promotion -Wshadow -march=native -fno-rtti -flto -fPIC -MD -MT grapher/CMakeFiles/grapher.dir/lib/grapher/utils/cli.cpp.o -MF grapher/CMakeFiles/grapher.dir/lib/grapher/utils/cli.cpp.o.d -o grapher/CMakeFiles/grapher.dir/lib/grapher/utils/cli.cpp.o -c /Users/vagrant/Data/buildtrees/ctbench/src/v1.3.3-f96a0799ba.clean/grapher/lib/grapher/utils/cli.cpp
FAILED: grapher/CMakeFiles/grapher.dir/lib/grapher/utils/cli.cpp.o 
/Library/Developer/CommandLineTools/usr/bin/c++  -I/Users/vagrant/Data/buildtrees/ctbench/src/v1.3.3-f96a0799ba.clean/grapher/include -isystem /Users/vagrant/Data/installed/x64-osx/include -fPIC -g -std=gnu++20 -arch x86_64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX14.0.sdk -DJSON_NOEXCEPTION -Wall -Wextra -Werror -Wnull-dereference -Wold-style-cast -Wdouble-promotion -Wshadow -march=native -fno-rtti -flto -fPIC -MD -MT grapher/CMakeFiles/grapher.dir/lib/grapher/utils/cli.cpp.o -MF grapher/CMakeFiles/grapher.dir/lib/grapher/utils/cli.cpp.o.d -o grapher/CMakeFiles/grapher.dir/lib/grapher/utils/cli.cpp.o -c /Users/vagrant/Data/buildtrees/ctbench/src/v1.3.3-f96a0799ba.clean/grapher/lib/grapher/utils/cli.cpp
/Users/vagrant/Data/buildtrees/ctbench/src/v1.3.3-f96a0799ba.clean/grapher/lib/grapher/utils/cli.cpp:40:28: error: implicit instantiation of undefined template 'std::basic_istringstream<char>'
        std::istringstream iss(entry_dir.path().filename().stem());
                           ^
/Library/Developer/CommandLineTools/SDKs/MacOSX14.0.sdk/usr/include/c++/v1/iosfwd:128:32: note: template is declared here
    class _LIBCPP_TEMPLATE_VIS basic_istringstream;
                               ^
1 error generated.

This is caused by a missing include of sstream

@JPenuchot
Copy link
Owner

Hi ! Sorry for the delay, I somehow missed this PR. I'm merging that, thanks for the contribution :)

@JPenuchot JPenuchot merged commit 9102c92 into JPenuchot:main Sep 2, 2024
@Thomas1664 Thomas1664 deleted the fix-include branch September 2, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants