fix: check timelineTypes
when all
search clicked in timeline Graph
view.
#130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thank you for maintaining the tool :)
I found a issue that the graph was not drawn when
all
clicked in the timeline view, so I fixed it.What Changed
checking
timelineTypes
(A flag to identify thetable
view orgraph
view) whenall
clicked in the timeline view.Motivation and Context
The graph was not drawn when
all
is clicked(andGraph
selected) on the timeline view as follows.After investigating, I found that
createAlltimeline()
does not checktimelineTypes
as follows.https://github.com/JPCERTCC/LogonTracer/blob/v1.5.4/static/js/script.js#L1450-L1453
On the other hand, it is checked in
searchTimeline()
as follows.https://github.com/JPCERTCC/LogonTracer/blob/v1.5.4/static/js/script.js#L1475-L1479
So, I fixed that checking
timelineTypes
increateAlltimeline()
.Evidence
After fixing it, I confirmed that graph is drawn when
all
clicked.I would appreciate it if you could confirm it🙏