Skip to content

Remove duplicate Say To Me ID control #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
JLarky wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove duplicate Say To Me ID control #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/web/src/say-to-me/components/chat/VoiceNotesBanner.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ describe("Say To Me section", () => {
expect(markup).toContain('class="hover:underline">Say To Me</a>');
expect(markup).toContain('data-testid="say-to-me-widget-host"');
expect(markup).toContain('src="/api/say-to-me/embed/widget.js"');
expect(markup).toContain("say-to-me-widget");
expect(markup.match(/<say-to-me-widget\b/g)).toHaveLength(1);
expect(markup).not.toContain('aria-label="Copy Say To Me session mention"');
expect(markup).not.toContain('aria-label="Park session"');
expect(markup).toContain('aria-label="Play most recent voice note"');
expect(markup).toContain('data-speaking="false"');
Expand Down
16 changes: 0 additions & 16 deletions apps/web/src/say-to-me/components/chat/VoiceNotesBanner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,8 +401,6 @@ export function VoiceNotesBanner({
const [isCreatingSession, setIsCreatingSession] = useState(false);
const [reloadToken, setReloadToken] = useState(0);
const [timersOpen, setTimersOpen] = useState(false);
const { copyToClipboard: copySessionMention, isCopied: isSessionMentionCopied } =
useCopyToClipboard({ target: "session mention" });
const { showEnableSound, enableSound, reportPermissionIssue } = useSoundUnlock();
const { timers, now: timerNow, refresh: refreshTimers } = useSayToMeTimers(sessionId);
const [playingId, setPlayingId] = useState<string | null>(null);
Expand Down Expand Up @@ -687,20 +685,6 @@ export function VoiceNotesBanner({
</a>
</h2>
<div className="flex shrink-0 items-center gap-1 short:gap-0.5">
<Button
size="xs"
variant="ghost"
aria-label="Copy Say To Me session mention"
title="Copy Say To Me session mention"
className="h-6 w-6 shrink-0 justify-center px-0 font-mono text-[10px] text-muted-foreground hover:text-foreground short:h-5 short:w-5 short:text-[9px]"
onClick={() => copySessionMention(`say-to-me(${sessionId})`, undefined)}
>
{isSessionMentionCopied ? (
<CheckIcon className="size-3.5 short:size-3" aria-hidden />
) : (
"ID"
)}
</Button>
<SayToMeWidgetHost
sessionId={sessionId}
environmentId={environmentId}
Expand Down