0 upstream ical link fix #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An ical link is now available on /calendar.ics. It contains all the ctfs with their description and dates. This endpoint is protected with a token by default, the password can be changed/removed by the admin.
gen_random_bytes is more suited for crypto purpose
If it should be removed, this should be done in a seperate PR.
Adds /calendar.ics route to frontend Fixes changing the ical key slight frontend changes when displaying the ical link
This reduced code redundancy
* Fix eslint errors * Fix insecure randomness in Registration.vue
Note: Users can still send requests which yield garbage responses, but this is not a security vulnerability because these responses are only served to the requesting user
Now it uses the password-input just like the registration password.
The dialog UI is confusing because you think that the key is short but actually it is out of view in the input field. Since the only action is to get the link of the ical, we just copy it to the clipboard immediately and show a confirmation checkmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the last issues of TFNS#146 and changes the UI slightly to obtain the ical URL.