allow '/dev/' prefix for <device> argument fix #25 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verified on MacOS Yosemite 10.10.5 and Ubuntu 19.10 both tested with and without '/dev/' prefix. This fixes JElchison#25 .
JElchison
added a commit
that referenced
this pull request
Feb 16, 2020
|
Hi again @walterav1984! Thanks for this PR. I appreciate your investment in this project! I have chosen to fix #25, #27, and #46 using a method that incurs less technical debt. I invite you to review my proposed combined fix here: ...and to test the fix using the version in this branch: If merged, these proposed fixes obsolete PRs #49 and #50. I look forward to your comments. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified on MacOS Yosemite 10.10.5 and Ubuntu 19.10 both tested with and without '/dev/' prefix. This fixes #25 .