Switch CI to spack-stack-1.5.0#39
Merged
Merged
Conversation
Collaborator
Author
|
Ohhh this is almost funny ... this requires a workaround in GOCART, for which I already have a branch in the ufs-weather-model. Might as well cherry-pick that commit so that future merges of the authoritative branches will be easier. |
Collaborator
Author
|
There is a PR for ufs-weather-model from a temporary branch to the branch used in ufs-bundle that needs to be merged if/once the regression tests pass, then the change of the branch name in |
shlyaeva
approved these changes
Sep 27, 2023
Collaborator
shlyaeva
left a comment
There was a problem hiding this comment.
Approving based on tests passing; sounds like lots of interesting debugging.. Thank you @climbfuji !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update software stack to spack-stack-1.5.0. To fix a compilation problem for ATMAERO, I had to push a small change to the fv3-jedi branch feature/ufs_dom (https://github.com/JCSDA-internal/fv3-jedi/commit/288a9288124314d5cb21e297ee66f70ef5ba3dcd) - see GEOS-ESM/GOCART#254 for more information.
Issue(s) addressed
n/a
Dependencies
n/a
Impact
n/a
Checklist
I have made corresponding changes to the documentation