Removed SOCA linkages for now and put them in a branch#3
Removed SOCA linkages for now and put them in a branch#3mark-a-potts wants to merge 2 commits intodevelopfrom
Conversation
| ecbuild_bundle( PROJECT fv3-jedi GIT "https://github.com/jcsda-internal/fv3-jedi.git" BRANCH feature/ufs UPDATE ) | ||
| endif() | ||
| ecbuild_bundle( PROJECT femps GIT "https://github.com/jcsda-internal/femps.git" BRANCH develop UPDATE ) | ||
| ecbuild_bundle( PROJECT fv3-jedi GIT "https://github.com/jcsda-internal/fv3-jedi.git" BRANCH feature/ufs UPDATE ) |
There was a problem hiding this comment.
Does the branch fv3-jedi::feature/ufs need to be merged into develop first or is this just temporary?
aerorahul
left a comment
aerorahul
left a comment
There was a problem hiding this comment.
Changes look good. I just have 1 question that needs clarification.
|
I have a PR in for the changes to fv3-jedi, so if that gets through, then we would want to change to develop for fv3-jedi and fv3-jedi-lm. |
|
Just added a PR for fv3-jedi-lm as well. Those changes are minor, but necessary. |
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
This looks good to me, sorry for the very late review. There is a question from @aerorahul that still needs to be answered. I assumed for my review that the feature/ufs branch is temporary.
| if(NOT UFS_APP MATCHES "^(ATM|NG-GODAS|S2S)$") | ||
| ecbuild_error("Valid options for -DUFS_APP are ATM|NG-GODAS|S2S") | ||
| if(NOT UFS_APP MATCHES "^(ATM)$") | ||
| ecbuild_error("Only -DUFS_APP=ATM is currently supported") |
|
@mark-a-potts I am finally getting to this, will test the ufs-jedi-bundle and the fv3-jedi-bundle on my mac with the changes to this repo, fv3-jedi and fv3-jedi-data. |
|
@mark-a-potts @aerorahul This PR is aging off pretty quickly. Are there PRs that need to be merged first? This was a question that Rahul had a while back. Thanks. |
|
Superseded by #9 |
4 participants
Description
This PR sets up the ufs-jedi-bundle to build with UFS in ATM-only mode.
Development work will continue on a branch to add in SOCA via UFS.
Definition of Done
The UFS related regression tests can be run via CI.
Issue(s) addressed
Dependencies
Impact
FV3-bundle should also be updated to remove the UFS option for building.
If changes in this PR require updating test data on AWS please add an "update test data" label and list the test data that needs to be updated to the best of your knowledge (example below).
Requires updating AWS test data for the following repositories:
ufs-c48 test data needs to be uploaded.