Feature/update apr13 by cmgas · Pull Request #26 · JCSDA/ufs-bundle

cmgas · 2023-04-13T22:40:03Z

Description

Update with develop on april 13.

Waiting on
JCSDA-internal/fv3-jedi-data#71
JCSDA-internal/soca#864
https://github.com/JCSDA-internal/fv3-jedi/pull/847

shlyaeva

Tested for ATM, works as expected. soca branch is missing on the remote, so I haven't tested the rest yet.

shlyaeva · 2023-04-17T18:16:05Z

CMakeLists.txt

  ecbuild_bundle( PROJECT femps    GIT "https://github.com/jcsda-internal/femps.git"    TAG 1.2.0 )
-  ecbuild_bundle( PROJECT fv3-jedi GIT "https://github.com/jcsda-internal/fv3-jedi.git" BRANCH feature/ufs_dom )  # updated from develop on jan28
-  ecbuild_bundle( PROJECT soca     GIT "https://github.com/jcsda-internal/soca.git"     BRANCH feature/ufs_dom )  # updated from develop on jan28
+  ecbuild_bundle( PROJECT fv3-jedi GIT "https://github.com/jcsda-internal/fv3-jedi.git" BRANCH feature/ufs_clem_update )  # updated from develop on jan28


This could be updated to feature/ufs_dom once fv3-jedi PR is merged

CMakeLists.txt

climbfuji · 2023-04-17T19:32:15Z

Testing this now!

shlyaeva

couldn't test with soca on platform/compiler of choice, approving based on tests with ATM.

climbfuji · 2023-04-18T14:54:29Z

This doesn't work for me :-( On my Mac, I get the following error when I run the UFS ctests (warmstart):

1197: At line 47 of file /Users/heinzell/scratch/ufs-bundle/ufs-bundle-clem-apr13/fv3-jedi/src/fv3jedi/Utilities/fv3jedi_constants_mod.f90
1197: Fortran runtime error: Different CHARACTER lengths (7/1) in array constructor
1197: At line 47 of file /Users/heinzell/scratch/ufs-bundle/ufs-bundle-clem-apr13/fv3-jedi/src/fv3jedi/Utilities/fv3jedi_constants_mod.f90
1197: Fortran runtime error: Different CHARACTER lengths (7/1) in array constructor
1197: At line 47 of file /Users/heinzell/scratch/ufs-bundle/ufs-bundle-clem-apr13/fv3-jedi/src/fv3jedi/Utilities/fv3jedi_constants_mod.f90
1197: Fortran runtime error: Different CHARACTER lengths (7/1) in array constructor
1197: At line 47 of file /Users/heinzell/scratch/ufs-bundle/ufs-bundle-clem-apr13/fv3-jedi/src/fv3jedi/Utilities/fv3jedi_constants_mod.f90
1197: Fortran runtime error: Different CHARACTER lengths (7/1) in array constructor
1197: At line 47 of file /Users/heinzell/scratch/ufs-bundle/ufs-bundle-clem-apr13/fv3-jedi/src/fv3jedi/Utilities/fv3jedi_constants_mod.f90
1197: Fortran runtime error: Different CHARACTER lengths (7/1) in array constructor
1197: At line 47 of file /Users/heinzell/scratch/ufs-bundle/ufs-bundle-clem-apr13/fv3-jedi/src/fv3jedi/Utilities/fv3jedi_constants_mod.f90
1197: Fortran runtime error: Different CHARACTER lengths (7/1) in array constructor
1197: [JCSDA-L-18146:79842] *** Process received signal ***

climbfuji

We'll need to fix the ufs warmstart error in fv3-jedi code on macOS

cmgas · 2023-04-18T16:34:54Z

Rebuilding now with latest develops

climbfuji · 2023-04-19T15:44:57Z

@cmgas This works now! The only thing that's needed on my macOS is updating the reference value for the ufs warmstart test:

difference between 355.7572273542616 and 356.73198629080974 is 0.97475893654814172, i.e. exceeds 0.035673198629080978 (FAIL)

CMakeLists.txt

climbfuji · 2023-04-19T19:26:27Z

Other good news: I was able to build the atmaero configuration on my macOS as well, will try ng-godas next

CMakeLists.txt

cmgas · 2023-04-19T20:43:14Z

@climbfuji When we merge the soca, fv3-jedi and fv3-jedi-data I will update the ufs-bundle PR

climbfuji · 2023-04-19T20:44:13Z

Would be nice to have a list of all PRs that this PR is waiting on in the description ...

climbfuji · 2023-04-20T03:01:39Z

Hmm, bad news at last. S2S compile failed on my macOS with:

[ 90%] Built target fv3jedi_addincrement.x
/Applications/Xcode.app/Contents/Developer/usr/bin/make  -f fv3-jedi/src/mains/CMakeFiles/fv3jedi_addincrement.x.schema.json.dir/build.make fv3-jedi/src/mains/CMakeFiles/fv3jedi_addincrement.x.schema.json.dir/depend
cd /Users/heinzell/scratch/ufs-bundle/build-debug-s2s && /usr/local/Cellar/cmake/3.23.1/bin/cmake -E cmake_depends "Unix Makefiles" /Users/heinzell/scratch/ufs-bundle/ufs-bundle-clem-apr13 /Users/heinzell/scratch/ufs-bundle/ufs-bundle-clem-apr13/fv3-jedi/src/mains /Users/heinzell/scratch/ufs-bundle/build-debug-s2s /Users/heinzell/scratch/ufs-bundle/build-debug-s2s/fv3-jedi/src/mains /Users/heinzell/scratch/ufs-bundle/build-debug-s2s/fv3-jedi/src/mains/CMakeFiles/fv3jedi_addincrement.x.schema.json.dir/DependInfo.cmake --color=
/Applications/Xcode.app/Contents/Developer/usr/bin/make  -f fv3-jedi/src/mains/CMakeFiles/fv3jedi_addincrement.x.schema.json.dir/build.make fv3-jedi/src/mains/CMakeFiles/fv3jedi_addincrement.x.schema.json.dir/build
cd /Users/heinzell/scratch/ufs-bundle/build-debug-s2s/etc && /Users/heinzell/scratch/ufs-bundle/build-debug-s2s/bin/fv3jedi_addincrement.x --output-json-schema=fv3jedi_addincrement.x.schema.json
dyld[72844]: Library not loaded: libpiof.dylib
  Referenced from: /Users/heinzell/scratch/ufs-bundle/build-debug-s2s/bin/fv3jedi_addincrement.x
  Reason: tried: 'libpiof.dylib' (no such file), '/usr/local/lib/libpiof.dylib' (no such file), '/usr/lib/libpiof.dylib' (no such file), '/Users/heinzell/scratch/ufs-bundle/build-debug-s2s/etc/libpiof.dylib' (no such file), '/usr/local/lib/libpiof.dylib' (no such file), '/usr/lib/libpiof.dylib' (no such file)
/bin/sh: line 1: 72844 Abort trap: 6           /Users/heinzell/scratch/ufs-bundle/build-debug-s2s/bin/fv3jedi_addincrement.x --output-json-schema=fv3jedi_addincrement.x.schema.json
make[2]: *** [fv3-jedi/src/mains/CMakeFiles/fv3jedi_addincrement.x.schema.json] Error 134
make[1]: *** [fv3-jedi/src/mains/CMakeFiles/fv3jedi_addincrement.x.schema.json.dir/all] Error 2
make: *** [all] Error 2

This works with the current ufs-bundle develop.

climbfuji · 2023-04-20T15:51:46Z

Hmm, bad news at last. S2S compile failed on my macOS with:

[ 90%] Built target fv3jedi_addincrement.x
/Applications/Xcode.app/Contents/Developer/usr/bin/make  -f fv3-jedi/src/mains/CMakeFiles/fv3jedi_addincrement.x.schema.json.dir/build.make fv3-jedi/src/mains/CMakeFiles/fv3jedi_addincrement.x.schema.json.dir/depend
cd /Users/heinzell/scratch/ufs-bundle/build-debug-s2s && /usr/local/Cellar/cmake/3.23.1/bin/cmake -E cmake_depends "Unix Makefiles" /Users/heinzell/scratch/ufs-bundle/ufs-bundle-clem-apr13 /Users/heinzell/scratch/ufs-bundle/ufs-bundle-clem-apr13/fv3-jedi/src/mains /Users/heinzell/scratch/ufs-bundle/build-debug-s2s /Users/heinzell/scratch/ufs-bundle/build-debug-s2s/fv3-jedi/src/mains /Users/heinzell/scratch/ufs-bundle/build-debug-s2s/fv3-jedi/src/mains/CMakeFiles/fv3jedi_addincrement.x.schema.json.dir/DependInfo.cmake --color=
/Applications/Xcode.app/Contents/Developer/usr/bin/make  -f fv3-jedi/src/mains/CMakeFiles/fv3jedi_addincrement.x.schema.json.dir/build.make fv3-jedi/src/mains/CMakeFiles/fv3jedi_addincrement.x.schema.json.dir/build
cd /Users/heinzell/scratch/ufs-bundle/build-debug-s2s/etc && /Users/heinzell/scratch/ufs-bundle/build-debug-s2s/bin/fv3jedi_addincrement.x --output-json-schema=fv3jedi_addincrement.x.schema.json
dyld[72844]: Library not loaded: libpiof.dylib
  Referenced from: /Users/heinzell/scratch/ufs-bundle/build-debug-s2s/bin/fv3jedi_addincrement.x
  Reason: tried: 'libpiof.dylib' (no such file), '/usr/local/lib/libpiof.dylib' (no such file), '/usr/lib/libpiof.dylib' (no such file), '/Users/heinzell/scratch/ufs-bundle/build-debug-s2s/etc/libpiof.dylib' (no such file), '/usr/local/lib/libpiof.dylib' (no such file), '/usr/lib/libpiof.dylib' (no such file)
/bin/sh: line 1: 72844 Abort trap: 6           /Users/heinzell/scratch/ufs-bundle/build-debug-s2s/bin/fv3jedi_addincrement.x --output-json-schema=fv3jedi_addincrement.x.schema.json
make[2]: *** [fv3-jedi/src/mains/CMakeFiles/fv3jedi_addincrement.x.schema.json] Error 134
make[1]: *** [fv3-jedi/src/mains/CMakeFiles/fv3jedi_addincrement.x.schema.json.dir/all] Error 2
make: *** [all] Error 2

This works with the current ufs-bundle develop.

I believe that this is an error in the parallelio package itself. Not sure why it didn't show up until now. I'll do a bit more digging if we can work around it, but in the meanwhile we should start merging the upstream dependencies of this PR.

climbfuji · 2023-04-20T15:53:46Z

The three upstream dependencies have been merged.

cmgas · 2023-04-20T16:13:05Z

@climbfuji I updated all the branches to be feature/ufs_dom

shlyaeva

Did not retest since the only changes since the last test are in branch names, I expect this to work as it did before. 🎉

cmgas and others added 2 commits April 13, 2023 15:04

update hashes

0c9c122

Update CMakeLists.txt

7ac8bcb

cmgas requested a review from climbfuji April 13, 2023 22:52

cmgas assigned shlyaeva and cmgas and unassigned shlyaeva Apr 13, 2023

cmgas requested a review from shlyaeva April 13, 2023 22:52

shlyaeva reviewed Apr 17, 2023

View reviewed changes

shlyaeva previously approved these changes Apr 17, 2023

View reviewed changes

climbfuji requested changes Apr 18, 2023

View reviewed changes

update apr 18

42d6139

build crtm

beec989

cmgas dismissed shlyaeva’s stale review via beec989 April 18, 2023 22:41

gitignore update

84e49a8

cmgas requested review from climbfuji and shlyaeva April 19, 2023 15:55

cmgas commented Apr 19, 2023

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

climbfuji requested changes Apr 19, 2023

View reviewed changes

climbfuji mentioned this pull request Apr 19, 2023

Update with develop JCSDA-internal/fv3-jedi-data#70

Closed

Comment out crtm build

40ecc4e

climbfuji mentioned this pull request Apr 20, 2023

Update with develop JCSDA-internal/fv3-jedi-data#71

Merged

shlyaeva previously approved these changes Apr 20, 2023

View reviewed changes

Update CMakeLists.txt to Dom's branches

2c20c06

cmgas dismissed shlyaeva’s stale review via 2c20c06 April 20, 2023 16:09

climbfuji approved these changes Apr 20, 2023

View reviewed changes

climbfuji requested a review from shlyaeva April 20, 2023 20:24

shlyaeva approved these changes Apr 20, 2023

View reviewed changes

climbfuji merged commit a4467b0 into develop Apr 20, 2023

climbfuji deleted the feature/update_apr13 branch April 20, 2023 20:58

Conversation

cmgas commented Apr 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

shlyaeva left a comment

Choose a reason for hiding this comment

Uh oh!

shlyaeva Apr 17, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

climbfuji commented Apr 17, 2023

Uh oh!

shlyaeva left a comment

Choose a reason for hiding this comment

Uh oh!

climbfuji commented Apr 18, 2023

Uh oh!

climbfuji left a comment

Choose a reason for hiding this comment

Uh oh!

cmgas commented Apr 18, 2023

Uh oh!

climbfuji commented Apr 19, 2023

Uh oh!

Uh oh!

climbfuji commented Apr 19, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cmgas commented Apr 19, 2023

Uh oh!

climbfuji commented Apr 19, 2023

Uh oh!

climbfuji commented Apr 20, 2023

Uh oh!

climbfuji commented Apr 20, 2023

Uh oh!

climbfuji commented Apr 20, 2023

Uh oh!

cmgas commented Apr 20, 2023

Uh oh!

shlyaeva left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cmgas commented Apr 13, 2023 •

edited

Loading