Skip to content

Bug fix in py-scipy for versions 1.8.0 to 1.14.0 (small_dynamic_array.h: error: reference to non-static member function must be called) spack #47620 - #483

Merged
climbfuji merged 2 commits into
JCSDA:spack-stack-devfrom
climbfuji:bugfix/scipy_llvm_spackstack
Nov 15, 2024

Conversation

@climbfuji

@climbfuji climbfuji commented Nov 15, 2024

Copy link
Copy Markdown
Collaborator

Description

This is the spack-stack-dev PR corresponding to spack develop PR spack#47620:

Bug fix in py-scipy for versions 1.8.0 to 1.14.0 that surfaces with latest Clang and Intel LLVM compilers. The error message is:

  >> 8899    FAILED: scipy/_lib/_uarray/_uarray.cpython-311-x86_64-linux-gnu.so.p/_uarray_dispatch.cxx.o
     8900      /home/dom/work/spack-stack-dev-20241107/spack/lib/spack/env/oneapi/icpx -Iscipy/_lib/_uarray/_uarray.cpython-311-x86_64-linux-gnu.so.p
             -Iscipy/_lib/_uarray -I../scipy/_lib/_uarray -I/home/dom/work/spack-stack-dev-20241107/envs/ue-oneapi-2025.0.0/install/oneapi/2025.0.0/py
             thon-3.11.7-d6nj3iw/include/python3.11 -fvisibility=hidden -fvisibility-inlines-hidden -fdiagnostics-color=always -DNDEBUG -D_FILE_OFFSET
             _BITS=64 -Wall -Winvalid-pch -std=c++14 -O3 -fPIC -Wno-terminate -Wno-unused-function -MD -MQ scipy/_lib/_uarray/_uarray.cpython-311-x86_
             64-linux-gnu.so.p/_uarray_dispatch.cxx.o -MF scipy/_lib/_uarray/_uarray.cpython-311-x86_64-linux-gnu.so.p/_uarray_dispatch.cxx.o.d -o sci
             py/_lib/_uarray/_uarray.cpython-311-x86_64-linux-gnu.so.p/_uarray_dispatch.cxx.o -c ../scipy/_lib/_uarray/_uarray_dispatch.cxx
     8901      warning: unknown warning option '-Wno-terminate' [-Wunknown-warning-option]
     8902      In file included from ../scipy/_lib/_uarray/_uarray_dispatch.cxx:3:
  >> 8903      ../scipy/_lib/_uarray/small_dynamic_array.h:145:18: error: reference to non-static member function must be called
     8904        145 |     size_ = copy.size;
     8905            |             ~~~~~^~~~
     8906      1 warning and 1 error generated.
     8907      [1053/1618] Compiling C object scipy/_lib/messagestream.cpython-311-x86_64-linux-gnu.so.p/meson-generated_messagestream.c.o
     8908      [1054/1618] Compiling C++ object scipy/_lib/_uarray/_uarray.cpython-311-x86_64-linux-gnu.so.p/vectorcall.cxx.o
     8909      warning: unknown warning option '-Wno-terminate' [-Wunknown-warning-option]

See scipy/scipy#21884 for a description and discussion and note that the developers said that this should be applied regardless of the compiler. I went back all the way to the first version of scipy where this particular file small_dynamic_array.h was added, and it already had the bug.

Testing

Tested with Intel oneAPI 2025.0.0 on Alma Linux.

@climbfuji climbfuji self-assigned this Nov 15, 2024
@climbfuji climbfuji changed the title Bug fix in py-scipy for versions 1.8.0 to 1.14.0 that surfaces with l… Bug fix in py-scipy for versions 1.8.0 to 1.14.0 (small_dynamic_array.h: error: reference to non-static member function must be called) spack #47620 Nov 15, 2024
@climbfuji
climbfuji marked this pull request as ready for review November 15, 2024 12:47
@climbfuji
climbfuji merged commit b274d59 into JCSDA:spack-stack-dev Nov 15, 2024
@climbfuji
climbfuji deleted the bugfix/scipy_llvm_spackstack branch November 15, 2024 16:37
climbfuji added a commit to JCSDA/spack-stack that referenced this pull request Nov 20, 2024
Add configuration for Intel oneAPI 2025.0.0 on Nautilus. This is with ifx, since there is no more ifort in oneapi@2025.0.0. This configuration is currently commented out, since the default is and should be 2024.2.1 with ifort for now.

This requires a bug fix in py-scipy in JCSDA/spack#483 (see there for more information and the upstream spack develop PR).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

2 participants