Fix cc wrapper#443
Merged
Merged
Conversation
climbfuji
approved these changes
Jun 14, 2024
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Thanks for the bug fix. I will note that the previous PR will not be merged into spack (develop) as is (working with the spack developers on it), therefore this PR will also need to be reverted. But for now, let's merge it.
Interesting that neither CI (Ubuntu, macOS), nor the systems I worked on (Oracle Linux, CentOS) had any issues with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes lib/spack/env/cc by making the Intel warning-related clauses added in commit d465fa0 POSIX compliant. Otherwise this script will fail on many OSes. See NOAA-EMC/UPP#974 (comment) and https://github.com/NOAA-EMC/UPP/actions/runs/9506866281/job/26205047049?pr=974 (and for that matter, https://stackoverflow.com/questions/229551/how-to-check-if-a-string-contains-a-substring-in-bash)