Rename the amsua_metop-c CRTM-fix file on copying#399
Merged
climbfuji merged 5 commits intoFeb 2, 2024
Conversation
1 task
Collaborator
|
@DavidHuber-NOAA Have you tested this PR? |
Collaborator
Author
|
@climbfuji Yes, I tested a before and after. The correct amsua_metop-c fix file is copied over and all other fix files are identical. |
climbfuji
approved these changes
Jan 31, 2024
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Thanks! Let's wait for @AlexanderRichert-NOAA to review this before I merge. We also need to find a way to backport this into the 1.6.0 release (I can take care of that).
Collaborator
|
@AlexanderRichert-NOAA Can you please review this PR? |
AlexanderRichert-NOAA
approved these changes
Feb 2, 2024
climbfuji
pushed a commit
that referenced
this pull request
Feb 2, 2024
This causes spack to copy the erroneously-placed fix file SpcCoeff/Little_Endian/amsua_metop-c_v2.SpcCoeff.bin when copying big-endian fix files (i.e. +big-endian) to the final fix directory as amsua_metop-c.SpcCoeff.bin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This causes spack to copy the erroneously-placed fix file
SpcCoeff/Little_Endian/amsua_metop-c_v2.SpcCoeff.binwhen copying big-endian fix files (i.e.+big-endian) to the finalfixdirectory asamsua_metop-c.SpcCoeff.bin.Issue(s) addressed
Resolves #963
Checklist