Updates required for creating binary (build) caches#231
Merged
climbfuji merged 5 commits intoFeb 25, 2023
Conversation
…/buildcache.py to enable building build caches for multiple packages without aborting after failures
… recursive symlink in source code after installation
…pack into feature/buildcaches
climbfuji
requested review from
AlexanderRichert-NOAA,
mark-a-potts,
srherbener and
ulmononian
climbfuji
force-pushed
the
feature/buildcaches
branch
from
684e5c4 to
7ed0fc6
Compare
Collaborator
Author
|
The CI test failure doesn't look like it is related to this PR (https://github.com/NOAA-EMC/spack/actions/runs/4263344812/jobs/7419969492): I think this PR is ready to go! |
Collaborator
Author
Ah, and rerunning it fixed it :-) |
srherbener
approved these changes
Feb 24, 2023
srherbener
left a comment
srherbener
left a comment
There was a problem hiding this comment.
Didn't test but changes look good to me.
ulmononian
approved these changes
Feb 24, 2023
Collaborator
ulmononian
left a comment
ulmononian
left a comment
There was a problem hiding this comment.
will be very nice to have this improved build cache feature. approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These updates are required for creating build caches for all packages in an environment by skipping packages with errors instead of aborting, which is what spack does at the moment. I created a corresponding issue and PR in the upstream spack repo: spack#35602 and spack#35601.
Note that the changes differ slightly from this PR due to the updates that went into spack develop in these files. I will take care of resolving the conflicts when we bring these changes down to our fork).
Testing
Tested successfully on my macOS. See JCSDA/spack-stack#484 for the corresponding spack-stack PR.