Bug fix for mapl when environment variable BASEDIR is set#229
Conversation
| # for an environment variable with the same name. This | ||
| # name is common and used all over the place, and if | ||
| # it is set it breaks the mapl build. Unset it here ... | ||
| env.unset("BASEDIR") |
There was a problem hiding this comment.
Oops. Sorry about this, @climbfuji. I added that code because users here didn't want to always pass in -DBASEDIR on the CMake line. I don't mind doing it, but users liked being able to do cmake -B build and all works.
There was a problem hiding this comment.
Not a problem at all, just wondering if we could use a safer name going forward, for example GEOS_BASEDIR or something like that?
There was a problem hiding this comment.
Well, if/when we go to Spack, we won't need it, so that's nice. Unfortunately, BASEDIR is pretty much embedded into the foundations of GEOS. Build system, run script, etc.
…pack into feature/mapl_basedir_buildcache_macos
climbfuji
changed the title
AlexanderRichert-NOAA
left a comment
AlexanderRichert-NOAA
left a comment
There was a problem hiding this comment.
Looks good. Tested with ufs-weather-model-static on hera just to be safe.
…pack into feature/mapl_basedir_buildcache_macos
3 participants
Description
Fixes a problem with
maplwhere the presence of the environment variableBASEDIRwrecks havoc for the build of the package. This environment variable isn't needed when using spack to buildmapland other GEOS packages. It's only needed when using the oldbaselibssystem developed by NASA.Tested with JCSDA/spack-stack#476.