Adapt to saber block interface change#982
Merged
travissluka merged 6 commits intodevelopfrom Dec 13, 2023
Merged
Conversation
symoore90
added
ALGO
travissluka
approved these changes
Dec 5, 2023
kbhargava
reviewed
Dec 5, 2023
Contributor
kbhargava
left a comment
kbhargava
left a comment
There was a problem hiding this comment.
Looks good but build fails again on orion. Might be due to the corresponding saber branch being out of date with the base branch.
Collaborator
Author
|
I've just updated the saber branch, that might help! |
Collaborator
Author
|
oops and saber PRs were merged, this can be merged now too |
Contributor
|
@kbhargava , or anyone, can you please review so I can merge. I no longer have admin privileges on SOCA so I can't merge unless there's 2 reviews |
ytremolet
approved these changes
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adapt to change in https://github.com/JCSDA-internal/saber/pull/727
build-group=https://github.com/JCSDA-internal/oops/pull/2454
build-group=https://github.com/JCSDA-internal/saber/pull/727