Change methods of saber blocks to take oops::FieldSet3D#978
Merged
Change methods of saber blocks to take oops::FieldSet3D#978
Conversation
travissluka
approved these changes
Nov 21, 2023
Contributor
travissluka
left a comment
travissluka
left a comment
There was a problem hiding this comment.
thanks @benjaminmenetrier for making the changes.
And, yes, this should be in SABER. The code is very soca specific at the moment, but once the atlas mesh connectivity stuff happens this quarter, I plan to rewrite this as a generic diffusion block that lives in SABER
shlyaeva
approved these changes
Nov 21, 2023
Collaborator
|
oops and saber PRs were merged, this PR is ready for merge now too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Surprisingly, there is now a SABER block in SOCA... I really think it should be part of SABER instead of SOCA to avoid this kind of companion PR.
Issue(s) addressed
None.
Testing
None.
Dependencies
Build tests with other unsubmitted packages.
build-group=JCSDA-internal/saber#720
build-group=JCSDA-internal/oops#2450
build-group=https://github.com/JCSDA-internal/fv3-jedi/pull/1088