Add OASIM and test obs to the repo... but don't do anything with it#937
Merged
travissluka merged 4 commits intodevelopfrom Aug 2, 2023
Merged
Add OASIM and test obs to the repo... but don't do anything with it#937travissluka merged 4 commits intodevelopfrom
travissluka merged 4 commits intodevelopfrom
Conversation
kbhargava
approved these changes
Aug 2, 2023
Contributor
kbhargava
left a comment
kbhargava
left a comment
There was a problem hiding this comment.
Tested building soca with the option -DBUILD_OASIM=ON on s4 using intel. Builds fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes Add OASIM to SOCA #925
OASIM can now be built with the soca bundle by setting
-DBUILD_OASIM=ONat ecbuild time. It is off by default.Sample obs were added. They were taken from the obs that are in ufo-data, except I changed their date to match the dates we use for our ctests
OASIM should now be built by default within TravisCI