Merged
Conversation
HamidehGMAO
approved these changes
Jul 28, 2023
Contributor
HamidehGMAO
left a comment
HamidehGMAO
left a comment
There was a problem hiding this comment.
Thanks Travis! Looks good to me for now. I will add the atmospheric variables like this. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of reading a state variable from a file, we can now add a "dummy" field with a constant value defined in
fields_metadata.yml(seedummy_atm1). This is useful for making progress on OASIM where we need atmospheric fields, but don't want to take the time to interpolate test atm fields to the MOM6 grid, especially given that coupled hofx will be available. We'll be able to run OASIM tests with standalone SOCA.(This "constant value field" feature might have other uses in the future that I can't think of at the moment?)
testing
A dummy field
dummy_atm1with fixed value of5.0has been added tofields_metadata.yml.hofx_3dhasdummy_atm1added to its state, which can be seen in the test reference output as being correctly set to5.0