changes to answers due to BUMP c0 -> si#920
Merged
travissluka merged 1 commit intodevelopfrom Jul 13, 2023
Merged
Conversation
Contributor
Author
|
@guillaumevernieres @kbhargava, I don't think the saber pr will break anything for either the regional or global 1/4, but if you notice bump diracs looking weird you can force bump to use the old |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
bump interpolation default changed from
c0tosi.Since we should be using the new default anyway, I just updated the reference answers. A quick look at the dirac output looks reasonable.