-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add structured grid and cmakelist edit #1057
base: develop
Are you sure you want to change the base?
Feature/add structured grid and cmakelist edit #1057
Conversation
@jrocha22 can you modify the PR description to fill out the requested items (describe what this adds, how it was tested, etc.) |
@jrocha22 we should talk about possibly adding a test that exercises this, if @travissluka wants us to add one |
yes, please add a ctest using one of the low res 5 deg files in soca, @jrocha22 let me know if you need guidance on how to add a ctest to soca. side note: wow, I'm surprised that works with such little code, good job model interface team! (@fmahebert ) |
@travissluka some ctest guidance would be great! thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I lost track of time, I meant to send you this last week:
For adding a ctest, take a look at the soca/test/CMakeLists.txt
file. Take a look at the hofx_3d
test for example. Do a search in that file and you'll see hofx_3d
in 3 places:
- The test is added with a
soca_add_test
command hereLine 597 in 92519ab
soca_add_test( NAME hofx_3d - The input yaml file has to have the same name as the test. In this case
testinput/hofx_3d.yaml
and it is added to the cmakelist file hereLine 58 in 92519ab
testinput/hofx_3d.yml - and last is the output reference file
testref/hofx_3d.yaml
added hereLine 120 in 92519ab
testref/hofx_3d.test testoutput/
directory, I just copy over the file fromtestoutput/
totestref/
, and the test should pass the next time you run it.
If you open testinput/hofx_3d.yaml
, at the very end you'll see the output and reference files mentioned in 2 and 3 above, here
soca/test/testinput/hofx_3d.yml
Line 232 in 92519ab
test: |
I hope that helps
Thanks @travissluka , @jrocha22 's summer with us is coming to a close, but either myself or @CatherineThomas-NOAA will help get this over the finish line with a test if Juliette is unable to |
Description
PR to add a ConvertToStructuredGrid executable to alter files to be in structured lat/lon grid for easier post processing.
CMakeLists.txt file edited to run executable
Issue(s) addressed
No associated issue number but resolves grid difficulties that might arise from further processing of files
Testing
New executable tested with twelve different high resolution (1440x1080x75) files and two low resolution (72x35x25) files from MOM6. Variables pulled were sea surface temperature and sea water potential temperature. All files ran through with no issues.
Executable tested with Hercules.
Are the changes covered by ctests? No (If not, tests should be added first.)